graded PR #26
Draft
graded PR #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added comments to targetrunner
… to specify the problem directory path containing the generator, model, and repair, rather than specifying each individual path. Right now it only works with essence problems but I can easily make it work with mzn problems as well. Only rule is that the problem needs to be called problem.essence, the generator generator.essence, and repair file repair.essence
This reverts commit 3aff897.
…nly need to specify the problem directory path containing the generator, model, and repair, rather than specifying each individual path. Right now it only works with essence problems but I can easily make it work with mzn problems as well. Only rule is that the problem needs to be called problem.essence, the generator generator.essence, and repair file repair.essence" This reverts commit 9328e76.
gradedpr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
in script: collect_results.py
fixed typo error while lead to a crash
in script: wrapper
changed dict key from 'solverMinTime' to 'minTime'
graded types from 'both' to 'all'
get_results() now returns both score and results, previously returned only score
we now add the 3 new parameters to the dict as well
if runtime is negative, make it positive (couldn't figure out why this was happening)
in script: setup.py
added 3 new parameters to read_config(args)
added parameter type to genSRTimeLimit and to genSolverTimeLimit
added options to parse those 3 parameters