Skip to content

Commit

Permalink
fix: Remove default values for rollingUpdate (#360)
Browse files Browse the repository at this point in the history
Co-authored-by: Zadkiel AHARONIAN <[email protected]>

#minor
  • Loading branch information
arielly-parussulo authored Dec 31, 2024
1 parent 50af088 commit 224cf3d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ helm delete --namespace test my-application
| deployment.annotations | object | `nil` | Annotations for Deployment. |
| deployment.additionalPodAnnotations | object | `nil` | Additional pod annotations. |
| deployment.strategy.type | string | `"RollingUpdate"` | Type of deployment strategy. |
| deployment.strategy.rollingUpdate.maxUnavailable | string | `"25%"` | Max unavailable pods during update. |
| deployment.strategy.rollingUpdate.maxSurge | string | `"25%"` | Max surge pods during update. |
| deployment.reloadOnChange | bool | `true` | Reload deployment if attached Secret/ConfigMap changes. |
| deployment.nodeSelector | object | `nil` | Select the node where the pods should be scheduled. |
| deployment.hostAliases | list | `nil` | Add host aliases to the pods. |
Expand Down
10 changes: 3 additions & 7 deletions application/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,9 @@ deployment:
# -- (string) Type of deployment strategy.
# @section -- Deployment Parameters
type: RollingUpdate
rollingUpdate:
# -- (string) Max unavailable pods during update.
# @section -- Deployment Parameters
maxUnavailable: 25%
# -- (string) Max surge pods during update.
# @section -- Deployment Parameters
maxSurge: 25%
# rollingUpdate:
# maxUnavailable: 25%
# maxSurge: 25%
# -- (bool) Reload deployment if attached Secret/ConfigMap changes.
# @section -- Deployment Parameters
reloadOnChange: true
Expand Down

0 comments on commit 224cf3d

Please sign in to comment.