Skip to content

Commit

Permalink
feat: warn the user of the deprecation of load-balancer-ip
Browse files Browse the repository at this point in the history
Warn the chart's user of the deprecation of the Service loadBalacerIP
field since Kubernetes v1.24.
  • Loading branch information
d3adb5 committed Jan 7, 2024
1 parent 7380d16 commit 5488bbc
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
8 changes: 8 additions & 0 deletions application/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{{- if .Values.service.loadBalancerIP }}
service.loadBalancerIP:
You have defined the value of service.loadBalancerIP for this release. Please
be mindful that this field has been deprecated as of Kubernetes v1.24 and may
be removed from the API in a later release.

Please refer to the Kubernetes documentation for more information.
{{- end }}
19 changes: 19 additions & 0 deletions application/tests/notes_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
suite: NOTES.txt

templates:
- NOTES.txt

tests:
- it: warns the user of the deprecation of loadBalancerIP
set:
service.loadBalancerIP: 1.1.1.1
asserts:
- matchRegexRaw:
pattern: 'service.loadBalancerIP:'

- it: does not emit a warning for loadBalancerIP when not set
set:
service.loadBalancerIP: null
asserts:
- notMatchRegexRaw:
pattern: 'service.loadBalancerIP:'

0 comments on commit 5488bbc

Please sign in to comment.