Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make cert manager certificate's commonName optional #major #369

Merged
merged 10 commits into from
Jan 6, 2025
Merged

feat: make cert manager certificate's commonName optional #major #369

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a61095
made cert manager certificate's commonName optional
owais-rehman Dec 31, 2024
faf3641
Added a description
owais-rehman Dec 31, 2024
e7151dd
Merge branch 'master' into update-certificate-template
owais-rehman Dec 31, 2024
cfd9ee0
minor changes
owais-rehman Jan 1, 2025
48a458c
correction
owais-rehman Jan 2, 2025
2ed9e43
Update sample value presentation
aslafy-z Jan 2, 2025
637240c
Update README.md
aslafy-z Jan 2, 2025
076969c
Update application/values.yaml
aslafy-z Jan 2, 2025
a39566e
Update application/values.yaml
aslafy-z Jan 2, 2025
f01a3ed
Update README.md
aslafy-z Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,8 @@ helm delete --namespace test my-application
| certificate.duration | string | `"8760h0m0s"` | The requested "duration" (i.e. lifetime) of the Certificate. |
| certificate.renewBefore | string | `"720h0m0s"` | The amount of time before the currently issued certificate's notAfter time that cert-manager will begin to attempt to renew the certificate. |
| certificate.subject | tpl/object | `nil` | Full X509 name specification for certificate. |
| certificate.commonName | string | `"admin-app"` | Common name as specified on the DER encoded CSR. |
| certificate.keyAlgorithm | string | `"rsa"` | Private key algorithm of the corresponding private key for this certificate. |
| certificate.commonName | string | `nil` | Common name as specified on the DER encoded CSR. |
owais-rehman marked this conversation as resolved.
Show resolved Hide resolved
| certificate.keyAlgorithm | string | `"rsa"` | Private key algorithm of the corresponding private key for this certificate. This field is not recommended in cases when this certificate is an end-entity certificate. More information can be found [here](https://cert-manager.io/docs/usage/certificate/#:~:text=%23%20Avoid%20using%20commonName,%3A%20example.com) |
| certificate.keyEncoding | string | `"pkcs1"` | Private key cryptography standards (PKCS) for this certificate's private key to be encoded in. |
| certificate.keySize | int | `2048` | Key bit size of the corresponding private key for this certificate. |
| certificate.isCA | bool | `false` | Mark this Certificate as valid for certificate signing. |
Expand Down
5 changes: 3 additions & 2 deletions application/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,9 @@ certificate:
# - Stockholm
# -- (string) Common name as specified on the DER encoded CSR.
owais-rehman marked this conversation as resolved.
Show resolved Hide resolved
# @section -- cert-manager Certificate Parameters
commonName: admin-app
# -- (string) Private key algorithm of the corresponding private key for this certificate.
commonName:
# admin-app
aslafy-z marked this conversation as resolved.
Show resolved Hide resolved
# -- (string) Private key algorithm of the corresponding private key for this certificate. This field is not recommended in cases when this certificate is an end-entity certificate. More information can be found [here](https://cert-manager.io/docs/usage/certificate/#:~:text=%23%20Avoid%20using%20commonName,%3A%20example.com)
owais-rehman marked this conversation as resolved.
Show resolved Hide resolved
# @section -- cert-manager Certificate Parameters
keyAlgorithm: rsa
# -- (string) Private key cryptography standards (PKCS) for this certificate's private key to be encoded in.
Expand Down
Loading