Fixes #25 #26
Open
Fixes #25 #26
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanch
reviewed
Jan 29, 2019
| @@ -51,9 +51,9 @@ object Primitives { | |||
| cellSpacing = Some(0), cellPadding = Some(6), cellBorder = Some(0), columns = Some("*"), | |||
| bgColor = Some(background), style = Some("rounded") | |||
| )) | |||
| val tooltip = anchorId.map(a ⇒ s"anchor-$a") | |||
| val tooltip = tip.orElse(anchorId.map(a ⇒ s"anchor-$a")) | |||
There was a problem hiding this comment.
Would this create extra anchors as a side effect and therefore affect alignment? Maybe if “pretty” tooltips are important, it would be better to use some other mechanism for anchors.
| val renderer = Renderer( | ||
| renderingOptions = RenderingOptions( | ||
| density = 75, | ||
| nodeURLs = Map("1" -> "http://www.example.org", "2" -> "http://www.foobar.org"), |
There was a problem hiding this comment.
Could you give a real-life example of the URL you would use?
There was a problem hiding this comment.
Another thing, I am not sure I like the idea of attaching this to internal ids, because those ids are not guessable or even deterministic. Is it important to you to specify the tip explicitly? What if reftree generated tips automatically using toString or something like that? Or maybe it could just set all tooltips to an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.