[DO NOT MERGE YET] Reintroduce exponential backoff retry strategy for LM calls #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dbczumar <[email protected]>
Signed-off-by: dbczumar <[email protected]>
dbczumar
commented
Oct 30, 2024
| joblib~=1.3 | ||
| litellm<=1.49.1 | ||
| json-repair | ||
| litellm<=1.51.3 |
There was a problem hiding this comment.
This is the only material change to this file. Everything else is linting
There was a problem hiding this comment.
We're saying anything up to 1.51.3?
dbczumar
changed the title
okhat
reviewed
Oct 30, 2024
| **kwargs, | ||
| ) | ||
|
|
||
|
|
||
| def _get_litellm_retry_strategy_kwargs() -> Dict[str, str]: |
There was a problem hiding this comment.
I fear this adds complexity that future maintainers of this file will not fully appreciate.
Maybe we just wait a bit and then just require recent litellm, i.e. >= 1.51.3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce exponential backoff retry strategy for LM calls