Compiler v2 asset mapping #4370

welbon · 2025-01-08T03:41:16Z

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

…k_module_address`

…s initialization function to avoid modifying the initial call of the Package

…used as tool codes

… old token string with Object<Metadata>; 3. Append test `test_asset_mapping_proof_coin_type_name`

…t support vector<vector<u8>>, we need to put all the data into a separate vector<u8> parameter when passing the proof parameter `sibilings`, and split it with `|` to ensure that the move layer can receive it smoothly.

coderabbitai · 2025-01-08T03:41:23Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-08T05:21:47Z

Benchmark for `1e185c2`

Click to view benchmark

Test	Base	PR	%
accumulator_append	826.4±122.59µs	893.9±232.70µs	+8.17%
block_apply/block_apply_10	524.1±32.38ms	521.0±33.44ms	-0.59%
block_apply/block_apply_1000	58.6±3.68s	60.9±1.61s	+3.92%
get_with_proof/db_store	44.3±2.23µs	49.5±8.51µs	+11.74%
get_with_proof/mem_store	38.6±5.45µs	36.0±1.05µs	-6.74%
put_and_commit/db_store/1	121.2±7.02µs	116.2±9.89µs	-4.13%
put_and_commit/db_store/10	1165.9±126.37µs	1120.3±71.40µs	-3.91%
put_and_commit/db_store/100	12.6±2.22ms	9.8±0.47ms	-22.22%
put_and_commit/db_store/5	629.1±88.71µs	537.7±28.74µs	-14.53%
put_and_commit/db_store/50	5.5±0.71ms	5.0±0.24ms	-9.09%
put_and_commit/mem_store/1	78.4±15.82µs	70.8±7.26µs	-9.69%
put_and_commit/mem_store/10	699.1±87.65µs	647.3±55.54µs	-7.41%
put_and_commit/mem_store/100	6.6±0.47ms	6.9±0.70ms	+4.55%
put_and_commit/mem_store/5	345.0±49.83µs	357.1±57.34µs	+3.51%
put_and_commit/mem_store/50	3.4±0.24ms	3.3±0.31ms	-2.94%
query_block/query_block_in(10)_times(100)	12.3±0.61ms	12.5±0.88ms	+1.63%
query_block/query_block_in(10)_times(1000)	202.6±33.08ms	129.5±10.81ms	-36.08%
query_block/query_block_in(10)_times(10000)	1354.3±135.94ms	1352.2±286.34ms	-0.16%
query_block/query_block_in(1000)_times(100)	1438.3±186.34µs	1351.3±98.53µs	-6.05%
query_block/query_block_in(1000)_times(1000)	12.8±1.10ms	12.3±0.38ms	-3.91%
query_block/query_block_in(1000)_times(10000)	147.4±23.33ms	126.6±7.43ms	-14.11%
storage_transaction	970.7±393.93µs	983.1±345.57µs	+1.28%
vm/transaction_execution/1	683.7±43.94ms	661.5±23.68ms	-3.25%
vm/transaction_execution/10	246.1±11.85ms	249.9±12.43ms	+1.54%
vm/transaction_execution/20	242.3±14.58ms	255.8±10.74ms	+5.57%
vm/transaction_execution/5	281.8±10.82ms	284.9±15.81ms	+1.10%
vm/transaction_execution/50	293.7±21.72ms	303.0±24.92ms	+3.17%

…mapping process

github-actions · 2025-01-09T10:47:20Z

Benchmark for `baf96ad`

Click to view benchmark

Test	Base	PR	%
accumulator_append	864.8±162.00µs	874.1±185.81µs	+1.08%
block_apply/block_apply_10	508.3±76.60ms	533.1±31.42ms	+4.88%
block_apply/block_apply_1000	59.7±2.74s	64.6±3.27s	+8.21%
get_with_proof/db_store	45.3±2.86µs	46.2±4.80µs	+1.99%
get_with_proof/mem_store	36.9±2.44µs	39.1±4.74µs	+5.96%
put_and_commit/db_store/1	140.6±24.58µs	130.8±14.45µs	-6.97%
put_and_commit/db_store/10	1226.1±195.31µs	1276.2±234.30µs	+4.09%
put_and_commit/db_store/100	11.5±1.58ms	13.1±2.39ms	+13.91%
put_and_commit/db_store/5	606.2±84.22µs	557.8±43.12µs	-7.98%
put_and_commit/db_store/50	6.6±1.42ms	5.8±1.05ms	-12.12%
put_and_commit/mem_store/1	73.3±9.64µs	73.5±11.98µs	+0.27%
put_and_commit/mem_store/10	702.6±86.85µs	704.5±106.39µs	+0.27%
put_and_commit/mem_store/100	7.4±1.42ms	7.5±1.31ms	+1.35%
put_and_commit/mem_store/5	346.7±39.06µs	341.7±45.57µs	-1.44%
put_and_commit/mem_store/50	3.6±0.72ms	3.6±0.40ms	0.00%
query_block/query_block_in(10)_times(100)	13.0±1.59ms	13.4±0.76ms	+3.08%
query_block/query_block_in(10)_times(1000)	143.2±11.43ms	125.7±7.78ms	-12.22%
query_block/query_block_in(10)_times(10000)	1367.1±228.12ms	1318.9±128.98ms	-3.53%
query_block/query_block_in(1000)_times(100)	1596.7±240.24µs	1224.7±59.83µs	-23.30%
query_block/query_block_in(1000)_times(1000)	14.3±2.31ms	13.7±1.99ms	-4.20%
query_block/query_block_in(1000)_times(10000)	139.3±17.05ms	127.4±9.78ms	-8.54%
storage_transaction	1189.6±532.06µs	1126.1±439.56µs	-5.34%
vm/transaction_execution/1	661.2±56.92ms	699.6±45.90ms	+5.81%
vm/transaction_execution/10	242.6±9.96ms	283.2±24.73ms	+16.74%
vm/transaction_execution/20	252.4±14.20ms	258.7±19.86ms	+2.50%
vm/transaction_execution/5	302.2±22.67ms	291.0±9.12ms	-3.71%
vm/transaction_execution/50	287.3±15.32ms	316.8±19.68ms	+10.27%

github-actions · 2025-01-10T04:03:35Z

Benchmark for `56dbe10`

Click to view benchmark

Test	Base	PR	%
accumulator_append	830.8±116.56µs	827.5±127.05µs	-0.40%
block_apply/block_apply_10	502.7±43.95ms	502.0±17.41ms	-0.14%
block_apply/block_apply_1000	56.6±1.62s	61.5±1.81s	+8.66%
get_with_proof/db_store	45.6±3.55µs	46.6±4.24µs	+2.19%
get_with_proof/mem_store	36.8±3.10µs	46.2±8.32µs	+25.54%
put_and_commit/db_store/1	127.5±11.31µs	128.0±14.89µs	+0.39%
put_and_commit/db_store/10	1098.1±138.98µs	1092.1±86.99µs	-0.55%
put_and_commit/db_store/100	10.0±0.45ms	10.4±0.76ms	+4.00%
put_and_commit/db_store/5	617.6±97.24µs	608.2±121.42µs	-1.52%
put_and_commit/db_store/50	5.9±0.77ms	5.9±0.76ms	0.00%
put_and_commit/mem_store/1	71.4±8.99µs	74.9±11.07µs	+4.90%
put_and_commit/mem_store/10	664.4±58.84µs	764.1±147.12µs	+15.01%
put_and_commit/mem_store/100	6.7±0.47ms	6.6±0.43ms	-1.49%
put_and_commit/mem_store/5	395.3±123.36µs	457.4±115.04µs	+15.71%
put_and_commit/mem_store/50	3.4±0.40ms	3.3±0.29ms	-2.94%
query_block/query_block_in(10)_times(100)	11.9±0.46ms	12.2±0.65ms	+2.52%
query_block/query_block_in(10)_times(1000)	123.8±7.24ms	134.8±11.38ms	+8.89%
query_block/query_block_in(10)_times(10000)	1253.5±66.99ms	1284.7±49.29ms	+2.49%
query_block/query_block_in(1000)_times(100)	1170.5±30.48µs	1268.0±80.96µs	+8.33%
query_block/query_block_in(1000)_times(1000)	12.9±1.07ms	12.9±1.10ms	0.00%
query_block/query_block_in(1000)_times(10000)	120.7±2.80ms	120.9±4.29ms	+0.17%
storage_transaction	1198.6±540.46µs	1192.4±552.17µs	-0.52%
vm/transaction_execution/1	618.6±25.81ms	667.2±21.42ms	+7.86%
vm/transaction_execution/10	232.0±7.53ms	252.9±8.60ms	+9.01%
vm/transaction_execution/20	231.0±12.85ms	240.9±11.47ms	+4.29%
vm/transaction_execution/5	276.1±17.35ms	285.4±13.49ms	+3.37%
vm/transaction_execution/50	282.1±17.66ms	296.1±15.05ms	+4.96%

github-actions · 2025-01-11T10:23:13Z

Benchmark for `c5b4ce6`

Click to view benchmark

Test	Base	PR	%
accumulator_append	1069.2±263.71µs	1092.3±216.34µs	+2.16%
block_apply/block_apply_10	572.9±119.25ms	507.6±7.85ms	-11.40%
block_apply/block_apply_1000	59.5±3.85s	61.1±1.43s	+2.69%
get_with_proof/db_store	55.2±10.13µs	45.5±2.87µs	-17.57%
get_with_proof/mem_store	37.0±2.89µs	35.8±0.58µs	-3.24%
put_and_commit/db_store/1	142.1±21.65µs	118.9±14.38µs	-16.33%
put_and_commit/db_store/10	1283.5±280.13µs	1307.0±229.92µs	+1.83%
put_and_commit/db_store/100	13.1±2.55ms	10.4±1.12ms	-20.61%
put_and_commit/db_store/5	618.0±76.10µs	565.9±36.67µs	-8.43%
put_and_commit/db_store/50	6.0±1.20ms	5.0±0.44ms	-16.67%
put_and_commit/mem_store/1	75.6±13.01µs	70.9±6.86µs	-6.22%
put_and_commit/mem_store/10	949.5±170.29µs	694.6±96.67µs	-26.85%
put_and_commit/mem_store/100	9.3±1.85ms	9.5±1.51ms	+2.15%
put_and_commit/mem_store/5	374.7±54.13µs	354.4±44.45µs	-5.42%
put_and_commit/mem_store/50	3.5±0.50ms	3.4±0.49ms	-2.86%
query_block/query_block_in(10)_times(100)	12.0±0.98ms	12.7±0.49ms	+5.83%
query_block/query_block_in(10)_times(1000)	133.8±10.88ms	118.1±6.56ms	-11.73%
query_block/query_block_in(10)_times(10000)	1308.0±88.03ms	1278.9±74.80ms	-2.22%
query_block/query_block_in(1000)_times(100)	1513.8±330.35µs	1199.4±64.36µs	-20.77%
query_block/query_block_in(1000)_times(1000)	12.1±0.16ms	13.1±2.64ms	+8.26%
query_block/query_block_in(1000)_times(10000)	132.7±12.84ms	121.5±5.47ms	-8.44%
storage_transaction	1234.4±474.62µs	1222.9±524.36µs	-0.93%
vm/transaction_execution/1	684.6±80.77ms	819.5±92.75ms	+19.70%
vm/transaction_execution/10	253.1±25.58ms	306.2±30.14ms	+20.98%
vm/transaction_execution/20	247.3±30.14ms	308.9±37.23ms	+24.91%
vm/transaction_execution/5	287.8±16.61ms	341.8±29.30ms	+18.76%
vm/transaction_execution/50	279.7±19.78ms	343.0±43.38ms	+22.63%

welbon and others added 22 commits December 31, 2024 16:19

[asset-mapping] Added the move code for asset mapping

4e6f4c8

[asset-mapping] fixed the function name

9de5f58

[asset-mapping] Added the move code for asset mapping

269e06a

[asset-mapping] fixed initalize_proof

c32b096

[asset-mapping] Restore the deployment address check related to `chec…

960777c

…k_module_address`

[asset-mapping] Put the relevant fields of proof root into the genesi…

0785215

…s initialization function to avoid modifying the initial call of the Package

[asset-mapping] Put the relevant fields of proof root into the genesi…

af5ed06

…s initialization function to avoid modifying the initial call of the Package

[asset-mapping] Add relevant codes for on-chain proofs, which can be …

86f5338

…used as tool codes

[asset-mapping] removed unused code

6fed99e

[asset-mapping] reformat some codes

57bfdbf

[asset-mapping] reformat some codes

29274e5

[asset-mapping] add proof test for asset mapping

b98b969

[asset-mapping] Reorganized some Move codes

4a92b4e

[asset-mapping] commmit For hash test

d36a279

update test_sha3_256_diffrent_with_crypto_macro

2e1c55b

[asset-mapping] remove smt proof and add starcoin proof

fc5c593

[asset-mapping] split starcoin_proof.move to more files

c71ae37

[asset-mapping] 1. append starcoin verify into asset_mapping; 2. bind…

21f57e3

… old token string with Object<Metadata>; 3. Append test `test_asset_mapping_proof_coin_type_name`

[asset-mapping] add blob hash check

f05d016

[asset-mapping] add proof_value_hash to assign_to_account_with_proof

4587bca

[asset-mapping] add asset-mapping project

19e580a

welbon requested a review from nkysg as a code owner January 8, 2025 03:41

[asset-mapping] add test_asset_mapping_whole_process for whole asset …

0165271

…mapping process

[asset-mapping] reformat codes

c031cd9

[asset-mapping] reformat codes And add some debug logs

bf6dbad

[asset-mapping] add fake money for asset mapping assign

b25deba

welbon added 3 commits January 12, 2025 00:19

[asset-mapping] change implements for asset mapping

d9797b5

[asset-mapping] add basic test

4da80c5

[asset-mapping] add test for writeset of object

66dc4a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compiler v2 asset mapping #4370

Compiler v2 asset mapping #4370

welbon commented Jan 8, 2025

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

Compiler v2 asset mapping #4370

Are you sure you want to change the base?

Compiler v2 asset mapping #4370

Conversation

welbon commented Jan 8, 2025

Pull request type

What is the current behavior?

What is the new behavior?

Other information

coderabbitai bot commented Jan 8, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jan 8, 2025

Benchmark for 1e185c2

github-actions bot commented Jan 9, 2025

Benchmark for baf96ad

github-actions bot commented Jan 10, 2025

Benchmark for 56dbe10

github-actions bot commented Jan 11, 2025

Benchmark for c5b4ce6

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Benchmark for `1e185c2`

Benchmark for `baf96ad`

Benchmark for `56dbe10`

Benchmark for `c5b4ce6`