Skip to content

Commit

Permalink
refactor: change settings var name + description
Browse files Browse the repository at this point in the history
  • Loading branch information
marcuspang committed Oct 17, 2024
1 parent c9cc623 commit 803067d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions vscode-cairo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@
"default": {},
"markdownDescription": "Extra environment variables that will be passed to the `cairo-language-server` executable.\nUseful for passing e.g. `CAIRO_LS_LOG` for debugging."
},
"cairo1.enableStatusBar": {
"cairo1.showInStatusBar": {
"type": "boolean",
"default": true,
"description": "Show Cairo Language Server information",
"description": "Show CairoLS information in the status bar.",
"scope": "window"
}
}
Expand Down
2 changes: 1 addition & 1 deletion vscode-cairo/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as vscode from "vscode";

interface ConfigProps {
enableLanguageServer: boolean;
enableStatusBar: boolean;
showInStatusBar: boolean;
languageServerPath: string;
enableScarb: boolean;
preferScarbLanguageServer: boolean;
Expand Down
4 changes: 2 additions & 2 deletions vscode-cairo/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ export async function activate(extensionContext: vscode.ExtensionContext) {
ctx.log.warn("note: set `cairo1.enableLanguageServer` to `true` to enable it");
}

if (ctx.config.get("enableStatusBar")) {
if (ctx.config.get("showInStatusBar")) {
await setupStatusBar(ctx, client);
} else {
ctx.log.warn("status bar is disabled");
ctx.log.warn("note: set `cairo1.enableStatusBar` to `true` to enable it");
ctx.log.warn("note: set `cairo1.showInStatusBar` to `true` to enable it");
}
}

Expand Down
6 changes: 3 additions & 3 deletions vscode-cairo/src/statusBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const CAIRO_STATUS_BAR_COMMAND = "cairo1.statusBar.clicked";
export async function setupStatusBar(ctx: Context, client?: lc.LanguageClient) {
ctx.extension.subscriptions.push(
vscode.workspace.onDidChangeConfiguration((e) => {
if (e.affectsConfiguration("cairo1.enableStatusBar")) {
if (e.affectsConfiguration("cairo1.showInStatusBar")) {
updateStatusBar(ctx);
}
}),
Expand All @@ -30,9 +30,9 @@ export async function setupStatusBar(ctx: Context, client?: lc.LanguageClient) {

async function updateStatusBar(ctx: Context) {
const config = vscode.workspace.getConfiguration("cairo1");
const enableStatusBar = config.get<boolean>("enableStatusBar", true);
const showInStatusBar = config.get<boolean>("showInStatusBar", true);

if (enableStatusBar) {
if (showInStatusBar) {
ctx.statusBarItem.text = "Cairo";
ctx.statusBarItem.tooltip = "Cairo Language";

Expand Down

0 comments on commit 803067d

Please sign in to comment.