feat(sync): stop sync at block number from config for profiling

[nagmo-starkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[nagmo-starkware]

• feat(sync): stop sync at block number from config for profiling #1838 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nagmo-starkware and the rest of your teammates on Graphite

[yair-starkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nagmo-starkware and @ShahakShama)

a discussion (no related file):
Why do you want to merge this to main?

---

---

crates/papyrus_p2p_sync/src/stream_factory.rs line 116 at r1 (raw file):

                        current_block_number >= stop_sync_at_block_number
                    }) {
                        return;

Please add log

[nagmo-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama and @yair-starkware)

a discussion (no related file):

Previously, yair-starkware (Yair) wrote…

Why do you want to merge this to main?

I think it's useful to have the option to run profiling. this change is necessary for that

---

---

crates/papyrus_p2p_sync/src/stream_factory.rs line 116 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

Please add log

you'll get this:
ERROR P2P Sync stopped.
don't you think it's enough?

[yair-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nagmo-starkware and @ShahakShama)

---

crates/papyrus_p2p_sync/src/stream_factory.rs line 116 at r1 (raw file):

Previously, nagmo-starkware wrote…

you'll get this:
ERROR P2P Sync stopped.
don't you think it's enough?

I would prefer an informative message

[nagmo-starkware]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @ShahakShama and @yair-starkware)

---

crates/papyrus_p2p_sync/src/stream_factory.rs line 116 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

I would prefer an informative message

Done.

[yair-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

[codecov]

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 72.65%. Comparing base (577618a) to head (a4a0faa).
Report is 1 commits behind head on main.

Files	Patch %	Lines
crates/papyrus_node/src/main.rs	0.00%	7 Missing ⚠️
crates/papyrus_p2p_sync/src/stream_factory.rs	28.57%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   72.67%   72.65%   -0.03%     
==========================================
  Files         143      143              
  Lines       20287    20310      +23     
  Branches    20287    20310      +23     
==========================================
+ Hits        14744    14756      +12     
- Misses       3775     3784       +9     
- Partials     1768     1770       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yair-starkware]

Reviewable status: 2 of 7 files reviewed, all discussions resolved (waiting on @ShahakShama)