This repository has been archived by the owner on Dec 26, 2024. It is now read-only.
fix(common): fix state diff commitment calculation #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-starkware
previously approved these changes
Jun 23, 2024
There was a problem hiding this comment.
Please add a corresponding test
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
- Coverage 67.25% 67.22% -0.03%
==========================================
Files 136 136
Lines 17889 17892 +3
Branches 17889 17892 +3
==========================================
- Hits 12031 12028 -3
- Misses 4532 4536 +4
- Partials 1326 1328 +2 ☔ View full report in Codecov by Sentry. |
yair-starkware
force-pushed
the
yair/fix_state_diff_commitment
branch
from
21b109a to
541d7b9
Compare
dan-starkware
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is