Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): fix default image tag #2145

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

dan-starkware
Copy link
Collaborator

@dan-starkware dan-starkware commented Jun 25, 2024

This change is Reviewable

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.76%. Comparing base (f509075) to head (902407f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   65.77%   65.76%   -0.01%     
==========================================
  Files         135      135              
  Lines       17824    17824              
  Branches    17824    17824              
==========================================
- Hits        11723    11722       -1     
  Misses       4816     4816              
- Partials     1285     1286       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@dan-starkware dan-starkware added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit c6e2241 Jun 26, 2024
35 checks passed
@dan-starkware dan-starkware deleted the dan/deployments/default-image branch June 26, 2024 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants