Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add support to p2p #2212

Merged
merged 4 commits into from
Jul 17, 2024
Merged

feat(helm): add support to p2p #2212

merged 4 commits into from
Jul 17, 2024

Conversation

idan-starkware
Copy link
Contributor

@idan-starkware idan-starkware commented Jul 9, 2024

This change is Reviewable

@idan-starkware idan-starkware changed the title chore(helm): Add support to p2p chore(helm): add support to p2p Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (9a6175e) to head (4320c60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   66.23%   66.23%   -0.01%     
==========================================
  Files         139      139              
  Lines       18343    18343              
  Branches    18343    18343              
==========================================
- Hits        12150    12149       -1     
  Misses       4895     4895              
- Partials     1298     1299       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eranreshef-starkware eranreshef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: 2 of 6 files reviewed, all discussions resolved

@idan-starkware idan-starkware force-pushed the idan/helm-papyrus-p2p branch 2 times, most recently from 9ddd9ad to 1dc1db8 Compare July 16, 2024 09:21
@idan-starkware idan-starkware self-assigned this Jul 16, 2024
@idan-starkware idan-starkware changed the title chore(helm): add support to p2p feat(helm): add support to p2p Jul 16, 2024
Copy link
Collaborator

@eranreshef-starkware eranreshef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @idan-starkware)


deployments/helm/values.yaml line 11 at r5 (raw file):

# Ethereum node URL. A value for this variable is mandatory.
base_layer_node_url: https://base_url.example.com

this config field shouldn't get a default value because there is no default value that will work globally.


deployments/helm/values.yaml line 96 at r5 (raw file):

pvc:
  # Recommended size is at least 512Gi.
  size: 1Gi

as discussed verbally yesterday, either set the recommended size or don't set a size at all.

Copy link
Contributor Author

@idan-starkware idan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @eranreshef-starkware and @idan-starkware)


deployments/helm/values.yaml line 11 at r5 (raw file):

Previously, eranreshef-starkware (Eran Reshef) wrote…

this config field shouldn't get a default value because there is no default value that will work globally.

Done.


deployments/helm/values.yaml line 96 at r5 (raw file):

Previously, eranreshef-starkware (Eran Reshef) wrote…

as discussed verbally yesterday, either set the recommended size or don't set a size at all.

Done.

Copy link
Collaborator

@eranreshef-starkware eranreshef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 1 of 2 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)

@idan-starkware idan-starkware added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 3bb9411 Jul 17, 2024
35 checks passed
@idan-starkware idan-starkware deleted the idan/helm-papyrus-p2p branch July 17, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants