modify chart to support nodeSelector and tolerations #789
Conversation
Codecov Report
@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 69.42% 70.17% +0.74%
==========================================
Files 41 41
Lines 4278 4278
Branches 4278 4278
==========================================
+ Hits 2970 3002 +32
+ Misses 684 653 -31
+ Partials 624 623 -1 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eranreshef-starkware
requested review from
alon-dotan-starkware and
dan-starkware
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @eranreshef-starkware)
deployments/helm/values.yaml line 26 at r1 (raw file):
deployment: # Optional - nodeSelector node_selector:
nodeSelector
|
Previously, alon-dotan-starkware wrote…
done. I will make another PR to align everything to camleCase. |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eranreshef-starkware)
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is