fix(JSON-RPC): make the json schema validation fail when result is null

[nagmo-starkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[nagmo-starkware]

Current dependencies on/for this PR:

• main
  • PR Dvir/save tx status #888
    • PR add v0.4.0 not connected to endpoint #877
      • PR docs: readme update #916
      • PR fix v3 spec based on git tag #914
      • PR connect v0.4.0 to api endpoint #881
        • PR fix(JSON-RPC): make the json schema validation fail when result is null #958 👈
          • PR feat(JSON-RPC): add support for v0.4.0-rc3 #959

This comment was auto-generated by Graphite.

[codecov]

Codecov Report

Merging #958 (92ce648) into connect_v0.4.0_to_api_endpoint (fbf0184) will not change coverage.
The diff coverage is n/a.

❗ Current head 92ce648 differs from pull request most recent head 5d65d31. Consider uploading reports for the commit 5d65d31 to get more accurate results

@@                       Coverage Diff                       @@
##           connect_v0.4.0_to_api_endpoint     #958   +/-   ##
===============================================================
  Coverage                           74.26%   74.26%           
===============================================================
  Files                                  63       63           
  Lines                                5157     5157           
  Branches                             5157     5157           
===============================================================
  Hits                                 3830     3830           
  Misses                                604      604           
  Partials                              723      723           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ShahakShama]

Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @nagmo-starkware)

---

crates/papyrus_gateway/src/test_utils.rs line 73 at r1 (raw file):

}

// todo: nevo - schmea validates null as valid for an unknown reason should investigate in the

Split into two sentences:
Schema validates null as valid for an unknown reason. Should investigate in the future ...

---

crates/papyrus_gateway/src/test_utils.rs line 73 at r1 (raw file):

}

// todo: nevo - schmea validates null as valid for an unknown reason should investigate in the

Use correct TODO format and capitalization

// TODO(nevo): Schema

---

crates/papyrus_gateway/src/test_utils.rs line 73 at r1 (raw file):

}

// todo: nevo - schmea validates null as valid for an unknown reason should investigate in the

schmea -> Schema

---

crates/papyrus_gateway/src/test_utils.rs line 74 at r1 (raw file):

// todo: nevo - schmea validates null as valid for an unknown reason should investigate in the
// future and remove this function (use is_valid directly)

Instead of using should, use declarative dialect: "Investigate this and remove this function (use is_valid directly)

[ShahakShama]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)

[ShahakShama]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)