Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell action in CI + fix typos #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ClementWalter
Copy link

@ClementWalter ClementWalter commented May 9, 2023

As mentioned in #90, the spec entails some typo. So, proposition to add a spell checker in the CI, that would at least have caught the reported typo from #90

image

@ClementWalter ClementWalter changed the title y Add codespell action in CI + fix typos May 9, 2023
@ArielElp ArielElp self-requested a review May 11, 2023 08:56
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already merged the other PR fixing the description issue which I think creates conflicts. If you rebase I can merge the workflow addition.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ClementWalter)

@ClementWalter
Copy link
Author

@ArielElp

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ClementWalter)

@ClementWalter
Copy link
Author

hey @ArielElp , what should I do next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants