Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust fmt and clippy #8

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Rust fmt and clippy #8

merged 1 commit into from
Jun 25, 2024

Conversation

shaharsamocha7
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 commented Jun 20, 2024

This change is Reviewable

@shaharsamocha7 shaharsamocha7 marked this pull request as ready for review June 20, 2024 13:48
Copy link
Contributor Author

shaharsamocha7 commented Jun 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


scripts/clippy.sh line 3 at r1 (raw file):

#!/bin/bash

cargo +nightly-2024-01-04 clippy "$@" --all-targets --all-features -- -D warnings -D future-incompatible \

Line too long

Copy link
Contributor Author

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


scripts/clippy.sh line 3 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Line too long

Done.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Copy link
Contributor Author

shaharsamocha7 commented Jun 25, 2024

Merge activity

@shaharsamocha7 shaharsamocha7 changed the base branch from 06-20-Stwo_cairo_prover_rust_crate to main June 25, 2024 07:01
@shaharsamocha7 shaharsamocha7 merged commit 8a5d76d into main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants