Remove PreProcessedColumn Enum #968
Open
+2
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jan 8, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
f5399f2 to
008ed91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gali/use_preprocessed_column_trait #968 +/- ##
=====================================================================
Coverage ? 92.29%
=====================================================================
Files ? 105
Lines ? 14244
Branches ? 14244
=====================================================================
Hits ? 13147
Misses ? 1024
Partials ? 73 ☔ View full report in Codecov by Sentry. |
ohad-starkware
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
8d41b00 to
6c4e2e3
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
008ed91 to
f791b51
Compare
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
6c4e2e3 to
05e2eb6
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
f791b51 to
479f469
Compare
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
05e2eb6 to
64c2554
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
479f469 to
e127683
Compare
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
64c2554 to
e28c6ce
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
e127683 to
e7785d9
Compare
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
e28c6ce to
9f04a50
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
e7785d9 to
9a4841e
Compare
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
9f04a50 to
e43b9e4
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
9a4841e to
2d12f58
Compare
Gali-StarkWare
force-pushed
the
gali/use_preprocessed_column_trait
branch
from
e43b9e4 to
94c4e99
Compare
Gali-StarkWare
force-pushed
the
gali/remove_preprocessed_column_enum
branch
from
2d12f58 to
eacecc0
Compare
ohad-starkware
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.