Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move modifiers into selectable options in object filter selectors #5203

Merged

Conversation

WithoutPants
Copy link
Collaborator

Removes the modifier buttons from the Performer, Studio and Tags criterion editors in favour of selectable items that are (imo) more intuitive and use more user-friendly language:
image

Any and None are the equivalent of not null and is null respectively, and only show if nothing else is selected. If either of these are selected, then no other options are shown:

image

If one or more objects are selected, the Any of and Only options are made available. Any of is the equivalent of includes (instead of includes all), and only is the equivalent of equals.

image

These special items are shown in parentheses, italics and with a lower opacity to distinguish them from regular items.

Given that it's a single value field, the studio selector does not have the Any of or Only options.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Sep 3, 2024
@WithoutPants WithoutPants added this to the Version 0.28.0 milestone Oct 29, 2024
@WithoutPants WithoutPants merged commit f949fab into stashapp:develop Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant