-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markers can have end time #5311
Merged
Merged
Commits on Oct 17, 2024
-
Other metadata sources such as ThePornDB and timestamp.trade support end times for markers but Stash did not yet support saving those. This is a first step which only allows end time to be set either via API or via UI. Other aspects of Stash such as video player timeline are not yet updated to take end time into account. - User can set end time when creating or editing markers in the UI or in the API. - End time cannot be before start time. This is validated in the backend and for better UX also in the frontend. - End time is shown in scene details view or markers wall view if present. - Existing markers in the database will be updated to have -1 for end. - GraphQL API does not require end_seconds. Omitted end_seconds will default to -1.
Configuration menu - View commit details
-
Copy full SHA for 4240861 - Browse repository at this point
Copy the full SHA 4240861View commit details -
Add descriptions for 'seconds' and 'end_seconds' in GraphQL schema
- 'seconds' is the required start time of a marker (in seconds). - 'end_seconds' is an optional end time of a marker (in seconds). Both fields support decimals.
Configuration menu - View commit details
-
Copy full SHA for 5cbd01b - Browse repository at this point
Copy the full SHA 5cbd01bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 457939d - Browse repository at this point
Copy the full SHA 457939dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8ba563 - Browse repository at this point
Copy the full SHA f8ba563View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e47601 - Browse repository at this point
Copy the full SHA 9e47601View commit details -
Configuration menu - View commit details
-
Copy full SHA for 446e99a - Browse repository at this point
Copy the full SHA 446e99aView commit details
Commits on Nov 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c67c020 - Browse repository at this point
Copy the full SHA c67c020View commit details -
Using -1 as a null value isn't really ideal.
Configuration menu - View commit details
-
Copy full SHA for f7c732f - Browse repository at this point
Copy the full SHA f7c732fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa1d0bf - Browse repository at this point
Copy the full SHA fa1d0bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fc5ddf - Browse repository at this point
Copy the full SHA 2fc5ddfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.