Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers can have end time #5311

Merged
merged 10 commits into from
Nov 2, 2024
Merged

Commits on Oct 17, 2024

  1. Markers can have end time

    Other metadata sources such as ThePornDB and timestamp.trade support end times for markers but Stash did not yet support saving those. This is a first step which only allows end time to be set either via API or via UI. Other aspects of Stash such as video player timeline are not yet updated to take end time into account.
    
    - User can set end time when creating or editing markers in the UI or in the API.
    - End time cannot be before start time. This is validated in the backend and for better UX also in the frontend.
    - End time is shown in scene details view or markers wall view if present.
    - Existing markers in the database will be updated to have -1 for end.
    - GraphQL API does not require end_seconds. Omitted end_seconds will default to -1.
    MinasukiHikimuna committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4240861 View commit details
    Browse the repository at this point in the history
  2. Add descriptions for 'seconds' and 'end_seconds' in GraphQL schema

    - 'seconds' is the required start time of a marker (in seconds).
    - 'end_seconds' is an optional end time of a marker (in seconds).
    
    Both fields support decimals.
    MinasukiHikimuna committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5cbd01b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    457939d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f8ba563 View commit details
    Browse the repository at this point in the history
  5. Prettier fix

    MinasukiHikimuna committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9e47601 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    446e99a View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    c67c020 View commit details
    Browse the repository at this point in the history
  2. Make end_seconds nullable.

    Using -1 as a null value isn't really ideal.
    WithoutPants committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f7c732f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa1d0bf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2fc5ddf View commit details
    Browse the repository at this point in the history