Remove hardcoded API version from JS client (#272)

statamic-rad-pack · Jan 29, 2025 · 4e06d70 · 4e06d70
1 parent 4abeec9
commit 4e06d70
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/resources/js/shopify/client.js b/resources/js/shopify/client.js
@@ -6,7 +6,7 @@ import { createStorefrontApiClient } from '@shopify/storefront-api-client';
  */
 const client = createStorefrontApiClient({
     storeDomain: window.shopifyConfig.url,
-    apiVersion: '2024-04',
+    apiVersion: window.shopifyConfig.apiVersion ?? '2024-07',
     publicAccessToken: window.shopifyConfig.token,
 });
 

diff --git a/src/Tags/Shopify.php b/src/Tags/Shopify.php
@@ -77,7 +77,7 @@ public function productPrice()
     public function tokens()
     {
         return "<script>
-window.shopifyConfig = { url: '".(config('shopify.storefront_url') ?? config('shopify.url'))."', token: '".config('shopify.storefront_token')."' };
+window.shopifyConfig = { url: '".(config('shopify.storefront_url') ?? config('shopify.url'))."', token: '".config('shopify.storefront_token')."', apiVersion: '".(config('shopify.api_version') ?? '2024-07')."' };
 </script>";
     }
 

diff --git a/tests/Unit/TagsTest.php b/tests/Unit/TagsTest.php
@@ -23,7 +23,7 @@ public function outputs_shopify_tokens()
         config()->set('shopify.storefront_token', '1234');
 
         $this->assertEquals(str_replace(["\r", "\n"], '', "<script>
-window.shopifyConfig = { url: 'abcd', token: '1234' };
+window.shopifyConfig = { url: 'abcd', token: '1234', apiVersion: '2024-07' };
 </script>"),
             str_replace(["\r", "\n"], '', $this->tag('{{ shopify:tokens }}'))
         );