Update httpclient.nim move log to trace #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nwaku, when the node's user sends a request to their infura RPC, the token is being printed by default. This PR aims to avoid printing it by default and just if someone is interested in debugging any possible issue
vpavlin
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
LGTM, this should also help with spammy output of this lib in nwaku and codex in debug mode
Actually, @Ivansete-status would you mind going through the other files as well? The address is being logged again a few lines below for batch request and in websocket clients etc.
It would be probably good to not solve this ad-hoc of this one particular line, but make it in the whole lib.
WDYT?
|
It would, but if the goal of the library is to log the address, we cannot prevent logging the token which is part of the address (unless some obfuscation can be done). Not sure what a more reasonable approach than moving it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nwaku, when the node's user sends a request to their infura RPC, the token is being printed by default.
This PR aims to avoid printing it by default and just if someone is interested in debugging any possible issue