move attesting up from halfway to one third of the way through slots #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove attesting up from halfway to one third of the way through slots
arnetheduck
reviewed
Dec 11, 2019
Co-Authored-By: Jacek Sieka <[email protected]>
|
haha, wonder if my div3 fix works :) not sure we have the right operators for durations... |
Even if so, it'd be good to have them, so the code as suggested works. |
mratsim
approved these changes
Dec 11, 2019
mratsim
pushed a commit
that referenced
this pull request
Dec 18, 2019
…643) * per honest validator and naïve/simple aggregator attestation specs, move attesting up from halfway to one third of the way through slots * Update beacon_chain/beacon_node.nim Co-Authored-By: Jacek Sieka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethereum/eth2.0-specs/blob/v0.9.2/specs/validator/0_beacon-chain-validator.md#attesting says:
This is somewhat part of the naive/simple attestation PR sequence along with #629 -- due to #638
beacon_nodechanges enough to make it worthwhile to split out changes to existing code from new modules.The remaining timing-related change is to broadcast aggregations at 2/3 through each slot, by a similar wait-for-slot-to-start-then-schedule-2/3-through, but that's waiting for the combination of #638 and #629 to land, to avoid pointless/predictable merge conflicts.