VC: Electra fixes. #6631
Open
VC: Electra fixes. #6631
+2,077
−1,085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Oct 11, 2024
| voluntary_exit_signature_fork( | ||
| fork, capellaForkVersion, currentEpoch, forkConfig.get.denebEpoch) | ||
| fork, capellaForkVersion, currentEpoch, denebEpoch) |
There was a problem hiding this comment.
EIP-7044 means this shouldn't have to be adjusted each fork past Capella.
tersec
reviewed
Oct 11, 2024
| @@ -466,11 +467,17 @@ proc pollForSyncCommitteeDuties*(service: DutiesServiceRef) {.async.} = | |||
| res.add(sub) | |||
| res | |||
| if len(subscriptions) > 0: | |||
| let res = await vc.prepareSyncCommitteeSubnets(subscriptions) | |||
| let (res, reason) = | |||
There was a problem hiding this comment.
This usage pattern seems like what Result[..., string] does fairly naturally, encoding the exactly-one-at-a-time nature of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes Electra fixes for VC.
And
asyncraisesannotations for VC.