Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point to nixpkgs upgrade of status-go #16366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siddarthkay
Copy link
Contributor

Summary

This PR points to status-go changes made in status-im/status-go#5848

Just want to ensure that nixpkgs upgrade in status-go does not break naything in status-desktop

cc @status-im/desktop-qa

@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 66c6b13 #1 2024-09-20 09:44:04 ~7 min macos/aarch64 🍎dmg
✔️ 66c6b13 #1 2024-09-20 09:44:04 ~7 min tests/nim 📄log
66c6b13 #1 2024-09-20 09:48:49 ~11 min tests/ui 📄log
✔️ 66c6b13 #1 2024-09-20 09:48:59 ~11 min macos/x86_64 🍎dmg
✔️ 66c6b13 #1 2024-09-20 09:53:27 ~16 min linux-nix/x86_64 📦tgz
✔️ 66c6b13 #1 2024-09-20 09:54:54 ~17 min linux/x86_64 📦tgz
✔️ 66c6b13 #2 2024-09-20 10:15:24 ~12 min tests/ui 📄log

@status-im-auto
Copy link
Member

@dlipicar
Copy link
Contributor

@siddarthkay so it compiles and the squish tests passed. Do we need some dogfooding done? The changes to the nixpkgs seem to be mostly mobile-related, is there anything we can expect to go wrong for desktop?

@siddarthkay
Copy link
Contributor Author

@dlipicar : the nixpkgs change impact how status-go is built and interfacing of status-go with status-desktop.
If squish test passes and @status-im/desktop-qa do no find any major issues during their smoke test then I can go ahead and merge the changes in status-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants