feat(wallet): Update recipient data in send sign modal #17164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Cuteivist
force-pushed
the
feat/recipient-delegate-sign-modal-17114
branch
from
ed7058a to
07ea8f2
Compare
Jenkins Builds
|
caybro
reviewed
Jan 30, 2025
| ens [string] - ens of recipient | ||
| emoji [string] - emoji of recipient wallet | ||
| color [string] - color of recipient wallet | ||
| colorId [string] - colorId of recipient wallet |
There was a problem hiding this comment.
Suggested change
| colorId [string] - colorId of recipient wallet | |
| colorId [int] - colorId of recipient wallet |
There was a problem hiding this comment.
Also in the delegate itself, should be an int, not string
There was a problem hiding this comment.
Method that is always used together with it indicates it is string.
| @@ -67,6 +81,29 @@ QObject { | |||
| !!selectedAssetContractEntry.item ? | |||
| selectedAssetContractEntry.item.address: "" | |||
|
|
|||
| /** output property of the selected recipient address **/ | |||
There was a problem hiding this comment.
do these need to separate properties here? we can simple expose the item from here do the necessary logic in UI?
There was a problem hiding this comment.
They are passed as separate, because recipient can also be unknown address. In such case item would be empty.
I used separate properties to hide logic of checking for item availability. That way other components don't care whether it is wallet account or saved account or unknown address (only address property).
Khushboo-dev-cpp
approved these changes
Jan 30, 2025
Cuteivist
force-pushed
the
feat/recipient-delegate-sign-modal-17114
branch
from
07ea8f2 to
54c6ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17114
What does the PR do
Affected areas
Wallet - simple sign modal
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)