Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Onboarding): Seed Phrase Entry UX Issues #17187

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

caybro
Copy link
Member

@caybro caybro commented Feb 3, 2025

What does the PR do

Fixes a couple of UX issues in the EnterSeedPhrase component (cf respective commits):

  • focus last input field after paste
  • fix backspace, delete or overwrite with selected text
  • add regression QML tests
  • improve the SB corresponding SB page

Fixes #17105

Affected areas

Onboarding/Seedphrase

Architecture compliance

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Zaznam.obrazovky.z.2025-02-03.12-33-08.mp4

- update imports
- fix wrong filename in qmldir
- don't use hardcoded metrics
- fields can be cleared by selecting a word and pressing backspace or
delete

Iterates: #17105
- add a convenience Paste button
- make it possible to validate the seedphrase
@caybro caybro linked an issue Feb 3, 2025 that may be closed by this pull request
@caybro caybro changed the title 17105 new onboarding seed phrase entry ux issues fix(Onboarding): Seed Phrase Entry UX Issues Feb 3, 2025
@caybro caybro marked this pull request as ready for review February 3, 2025 11:34
@caybro caybro requested review from micieslak, alexjba and a team as code owners February 3, 2025 11:34
@caybro caybro requested review from glitchminer and igor-sirotin and removed request for a team February 3, 2025 11:34
@status-im-auto
Copy link
Member

status-im-auto commented Feb 3, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 437f6ca #1 2025-02-03 11:39:10 ~7 min macos/aarch64 🍎dmg
✔️ 437f6ca #1 2025-02-03 11:40:59 ~9 min tests/nim 📄log
✔️ 437f6ca #1 2025-02-03 11:44:03 ~12 min tests/ui 📄log
✔️ 437f6ca #1 2025-02-03 11:46:34 ~15 min macos/x86_64 🍎dmg
✔️ 437f6ca #1 2025-02-03 11:52:42 ~21 min linux-nix/x86_64 📦tgz
✔️ 437f6ca #1 2025-02-03 11:54:28 ~23 min linux/x86_64 📦tgz
✔️ 437f6ca #1 2025-02-03 11:54:48 ~23 min windows/x86_64 💿exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New onboarding: Seed Phrase Entry UX Issues
2 participants