feat(telemetry)_: send connection failure metric #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (10)
|
adklempner
force-pushed
the
feat/telemetry-conn-failure
branch
from
ce321af
to
570ef17
Compare
adklempner
force-pushed
the
feat/telemetry-conn-failure
branch
from
570ef17
to
261dfa8
Compare
adklempner
force-pushed
the
feat/telemetry-conn-failure
branch
from
261dfa8
to
a274a15
Compare
adklempner
commented
Aug 2, 2024
| @@ -125,6 +123,9 @@ func (w *Waku) broadcast() { | |||
| } | |||
| } | |||
|
|
|||
| // Wraps the publish function with rate limiter | |||
| fn = w.limiter.ThrottlePublishFn(w.ctx, fn) | |||
There was a problem hiding this comment.
@richard-ramos I moved the rate limit wrapper after the telemetry wrapper so that rate limiting doesn't get caught as a publish error
richard-ramos
approved these changes
Aug 2, 2024
vpavlin
approved these changes
Aug 3, 2024
igor-sirotin
approved these changes
Aug 5, 2024
Comment on lines
+384
to
+385
| body, _ := json.Marshal(postBody) | ||
| jsonRawMessage := json.RawMessage(body) |
There was a problem hiding this comment.
We marshal and unmarshal here 🤔. And then we marshal again here:
Line 230 in 780e3e5
It would be nice to reduce these procedures. We could change Client.TelemetryData type to interface{} and pass the postBody pointer directly. And then just call json.Marshal on it.
I guess it can be done out of this PR ofc.
Comment on lines
+107
to
+108
| nextIdLock sync.Mutex | ||
| nextId int |
There was a problem hiding this comment.
Just a suggestion, out of this PR
Suggested change
| nextIdLock sync.Mutex | |
| nextId int | |
| nextId atomic.Int32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary which serves as a squashed-commit message.
A description to understand introduced changes without reading the code.
Important changes:
Related to status-im/telemetry#21