chore_: ignore sensitive fields of WalletConfig when logging

[qfrank]

We used env to hide sensitive configuration, but there's a chance to write the sensitive data into log file, this PR fixed it.

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	f6c0e39	#1	2024-08-08 08:41:05	~2 min	tests-rpc	📄log
✔️	f6c0e39	#1	2024-08-08 08:42:28	~3 min	linux	📦zip
✔️	f6c0e39	#1	2024-08-08 08:42:57	~4 min	ios	📦zip
✔️	f6c0e39	#1	2024-08-08 08:44:02	~5 min	android	📦aar
✔️	f6c0e39	#1	2024-08-08 09:22:45	~44 min	tests	📄log

[igor-sirotin]

Good catch! Thank you!

Though I there's a drawback here. Adding a field that should be logged, will require user to keep in mind to add it to Marshal function.

I googled this solution, it looks much cleaner and scalable:

type SensitiveString string {}

func (SensitiveString s) String () string {
    return "****"
}

func (SensitiveString s) Value() string {
    return s
}

I guess we can merge as is and open an issue to fix all places for to use such approach.
cc @osmaczko

[osmaczko]

Good catch! Thank you!

Though I there's a drawback here. Adding a field that should be logged, will require user to keep in mind to add it to Marshal function.

I googled this solution, it looks much cleaner and scalable:

type SensitiveString string {}

func (SensitiveString s) String () string {
    return "****"
}

func (SensitiveString s) Value() string {
    return s
}

I guess we can merge as is and open an issue to fix all places for to use such approach. cc @osmaczko

Nice 👍 Although, it is not a silver bullet. It will not work with third-party types, including generated protobufs and ecdsa.PrivateKey, for instance.

[igor-sirotin]

Nice 👍 Although, it is not a silver bullet. It will not work with third-party types, including generated protobufs and ecdsa.PrivateKey, for instance.

@osmaczko for ecdsa.PrivateKey I once proposed this idea:

• Implement a single type to provide different forms of encryption keys #4273

Maybe we could also add some String() method that would return it as *** string for private key