Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : rename crypto phrases, buy Eth and buy assets #21404

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Oct 9, 2024

fixes #21396

It closes subtasks:

Summary

rename "buy ETH" -> "Add ETH" , "Buy assets" -> "Add assets", "Buy Assets" in title -> "Ways to buy assets"

Testing notes

No code changes, only labels. please check if e2e needs any adjustment.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3f87377 #2 2024-10-09 10:00:54 ~7 min android-e2e 🤖apk 📲
✔️ 3f87377 #2 2024-10-09 10:02:22 ~8 min tests 📄log
✔️ 3f87377 #2 2024-10-09 10:03:19 ~9 min android 🤖apk 📲
✔️ 3f87377 #2 2024-10-09 10:04:29 ~11 min ios 📱ipa 📲
✔️ dadff16 #3 2024-10-11 13:22:37 ~11 min android-e2e 🤖apk 📲
✔️ dadff16 #3 2024-10-11 13:27:35 ~16 min ios 📱ipa 📲
✔️ dadff16 #4 2024-10-11 13:52:14 ~4 min tests 📄log
✔️ dadff16 #4 2024-10-11 13:54:29 ~8 min android 🤖apk 📲

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 0
Passed tests: 7

Passed tests (7)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

Copy link
Member

@briansztamfater briansztamfater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Horupa-Olena Horupa-Olena self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment