Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use 1 content-topic for all chats within a community (not to merge) #21407

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chaitanyaprem
Copy link
Contributor

Summary

This PR is mainly to dogfood underlying changes made in status-go.

Reference PR status-im/status-go#5864 which has details.

This PR uses single content-topic for all community chats to send messages. It still receives messages on all existing content-topics used by previous versions in order to maintain compatibility.

Details of the discussion are available https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335/29

Testing notes

Platforms

  • Android
  • iOS

Areas that maybe impacted

Community chats and control flows

Functional
  • public chats
  • all community chats and control flows (channel creation, updation, deletion, permissions change, user add, user kick etc)
  • new account

Steps to test

  • This PR would require complete testing of communities in relay and light modes.
  • It would also require to be tested for compacibility with older version of the code.
  • Best to check all admin functions as well using this new code
  • We also need to validate if community admin is using older code and a member is using new code there are no incompatibilites.
  • All chats and community flows such as add member, remove member, add channel, delete channel, change permissions to channels etc

Risk

Described potential risks and worst case scenarios.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

-->

@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a0930bf #1 2024-10-09 10:38:32 ~5 min tests 📄log
✔️ a0930bf #1 2024-10-09 10:41:35 ~8 min android-e2e 🤖apk 📲
✔️ a0930bf #1 2024-10-09 10:42:45 ~9 min android 🤖apk 📲
✔️ a0930bf #1 2024-10-09 10:43:21 ~10 min ios 📱ipa 📲

@flexsurfer flexsurfer added status-go waku All issues relating to the Status Waku integration. labels Oct 9, 2024
@churik churik added the blocked label Oct 9, 2024
@churik
Copy link
Member

churik commented Oct 9, 2024

Blocking it until 2.31 is cut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked status-go waku All issues relating to the Status Waku integration.
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

4 participants