Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swap): update icon and don't show contract address for eth on confirmation screen #21410

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

briansztamfater
Copy link
Member

fixes #21322
fixes #21352

Summary

This PR fixes the icon which is the transaction icon in the Iconset (https://www.figma.com/design/qLLuMLfpGxK9OfpIavwsmK/Iconset?node-id=347-91&m=dev) and also don't show contract address for Ether transaction on the Swap confirmation screen (we were previously showing what is coming from status-go which is the zero address)

Screenshots

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

Issue #21322

  1. Login to app
  2. Turn on swaps feature flag
  3. Go to wallet
  4. Open any account
  5. Make a long tap on any token you have
  6. Verify the swap icon is the correct one

Issue #21352

  1. Go to the swap page and select ETH in the send or receive field.
  2. Navigate to the confirmation page.
  3. Verify that the field should be empty where the contract address is usually displayed

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
64fd8e1 #1 2024-10-09 23:00:24 ~4 min tests 📄log
✔️ 64fd8e1 #1 2024-10-09 23:03:50 ~7 min android-e2e 🤖apk 📲
✔️ 64fd8e1 #1 2024-10-09 23:04:22 ~8 min android 🤖apk 📲
✔️ 64fd8e1 #1 2024-10-09 23:10:08 ~14 min ios 📱ipa 📲
✔️ 64fd8e1 #2 2024-10-10 11:08:27 ~2 min tests 📄log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: REVIEW
Status: Code Review
2 participants