Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] test status-go changes in suggested fees #21941

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] test status-go changes in suggested fees #21941

wants to merge 1 commit into from

Conversation

briansztamfater
Copy link
Member

There are some sensitive changes being made in the router status-im/status-go#6243

So before merging that status-go PR, it would be great if someone from the @status-im/mobile-qa team could briefly smoke test our wallet main flows in this PR that includes those changes.

This PR will not be merged, its just for testing purposes.

@briansztamfater briansztamfater added request-manual-qa wallet-core Issues for mobile wallet team labels Jan 16, 2025
@briansztamfater briansztamfater self-assigned this Jan 16, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 16, 2025 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c61e48d #1 2025-01-16 15:24:50 ~6 min tests 📄log
✔️ c61e48d #1 2025-01-16 15:28:54 ~11 min android-e2e 🤖apk 📲
✔️ c61e48d #1 2025-01-16 15:29:39 ~11 min ios 📱ipa 📲
✔️ c61e48d #1 2025-01-16 15:30:24 ~12 min android 🤖apk 📲

@churik churik mentioned this pull request Jan 16, 2025
Merged
6 tasks
@status-im-auto
Copy link
Member

91% of end-end tests have passed

Total executed tests: 56
Failed tests: 4
Expected to fail tests: 1
Passed tests: 51

IDs of failed tests: 702786,702838,702839,704613 

IDs of expected to fail tests: 702844

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'new message' is under today
    Device 2: Looking for a message by text: new message 

    critical/chats/test_public_chat_browsing.py:359: in test_community_message_send_check_timestamps_sender_username
    self.channel_2.verify_message_is_under_today_text(new_message, self.errors, 60)
../views/chat_view.py:618: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element(timeout)
../views/base_element.py:138: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_community_message_delete, id: 702839

    Device 2: Find Button by xpath: //*[@text="Delete for everyone"]
    Device 2: Find Button by xpath: //*[@text="Delete for everyone"] 

    critical/chats/test_public_chat_browsing.py:389: in test_community_message_delete
    self.channel_2.delete_message_in_chat(message_to_delete_everyone)
../views/chat_view.py:667: in delete_message_in_chat
    delete_button.double_click()
../views/base_element.py:113: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:113: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:78: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="Delete for everyone"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'shudpAeBLUf7Jhtgbb54'
    Device 2: Looking for a message by text: shudpAeBLUf7Jhtgbb54 

    critical/chats/test_public_chat_browsing.py:963: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    # STEP: Opening profile 'zQ3...5XU1aa' by the url https://status.app/u#zQ3shVVxZMwLVEQvuu1KF6h4D2mzVyCC4F4mHLZm5dz5XU1aa
    Device 1: Find ChatMessageInput by accessibility id: chat-message-input 

    critical/test_deep_and_universal_links.py:39: in test_links_open_universal_links_from_chat
    self.channel.chat_message_input.clear()
../views/base_element.py:366: in clear
    self.find_element().clear()
../views/base_element.py:78: in find_element
    raise NoSuchElementException(
 Device 1: ChatMessageInput by accessibility id: `chat-message-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2]
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:650: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No preview is loaded for url https://youtu.be/Je7yErjEVt4
E    No preview is loaded for url https://www.youtube.com/watch?v=XN-SVmuJH2g&list=PLbrz7IuP1hrgNtYe9g6YHwHO6F3OqNMao
E    No preview is loaded for url https://m.youtube.com/watch?v=Je7yErjEVt4

    [[Youtube links preview is not loaded on LambdaTest emulators, needs investigation]]

    Device sessions

    Passed tests (51)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_mute_community_and_channel, id: 703382
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_discovery, id: 703503
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_message_edit, id: 702843
    Device sessions

    4. test_community_several_images_send_reply, id: 703194
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    8. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    6. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_balance_mainnet, id: 740490
    2. test_wallet_add_remove_regular_account, id: 727231

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestFallbackMultipleDevice:

    1. test_fallback_with_correct_seed_phrase, id: 740221
    2. test_fallback_sync_with_error, id: 740220
    3. test_fallback_add_key_pair, id: 741054
    4. test_fallback_validate_seed_phrase, id: 740222

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links_profile, id: 702775
    Device sessions

    2. test_deep_links_communities, id: 739307
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_add_contact_field_validation, id: 702777
    Device sessions

    3. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @saledjenic saledjenic mentioned this pull request Jan 16, 2025
    Merged
    @VolodLytvynenko VolodLytvynenko self-assigned this Jan 17, 2025
    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented Jan 17, 2025 •
    edited
    Loading

    @briansztamfater thank you for PR. Take a look found issue:

    ISSUE 1: Estimated time and max fee shown as "unknown" on approve and swap confirmation drawer

    Steps:

    1. Go to swap confirmation page
    2. Check max fee and estimated time

    Actual result:

    Estimated time and max fee shown as "unknown"

    image

    Expected result:

    Max fee and estimated time is fetched:

    • For approve: fee related for approve only
    • For swap: fee related for swap only

    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented Jan 17, 2025 •
    edited
    Loading

    The issue mentioned in this comment is not introduced by the current related Status Go PR (status-go#6243). This issue already exists in Status Go, as I verified in another mobile PR (status-mobile#21876) that also includes the status go.

    This means the current PR is not blocked by this issue. However, it should still be addressed because once we bump Status Go to our mobile develop branch, the issue will appear there as well.

    I’ve reported it separately #21948. @briansztamfater @saledjenic Could you please take a look at this issue requires some UI adjustments, or is it a Go-related problem?

    @VolodLytvynenko VolodLytvynenko mentioned this pull request Jan 17, 2025
    Open
    @VolodLytvynenko
    Copy link
    Contributor

    @briansztamfater Thank you for creating this PR. Just confirmed status-im/status-go#6243 (comment) merging status go PR

    @status-im-auto
    Copy link
    Member

    75% of end-end tests have passed

    Total executed tests: 4
Failed tests: 1
Expected to fail tests: 0
Passed tests: 3

    IDs of failed tests: 702786

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'shv4QLg1HeMhWEWaENLr'
    Device 2: Looking for a message by text: shv4QLg1HeMhWEWaENLr 

    critical/chats/test_public_chat_browsing.py:963: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:176: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention



    Device sessions

    Passed tests (3)

    Click to expand

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    @briansztamfater briansztamfater mentioned this pull request Jan 17, 2025
    Merged
    8 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees

    @briansztamfater briansztamfater

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa wallet-core Issues for mobile wallet team
    Projects
    Pipeline for QA
    Status: DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @briansztamfater @status-im-auto @VolodLytvynenko