Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tamagui #571

Closed
wants to merge 2 commits into from
Closed

update tamagui #571

wants to merge 2 commits into from

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Jun 6, 2024 •
edited
Loading

what

  • updates tamagui to the latest version which isn't experimenting with ESM
  • fixes ReferenceError: React is not defined
  • fixes @tamagui/image sizing in this updated version so Avatar display images
  • fixes components in this update version to use View from @tamagui/core

why

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2024

⚠️ No Changeset found

Latest commit: 57b0590

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024

@felicio is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

felicio
felicio commented Jun 6, 2024
View reviewed changes
packages/components/src/image/image.tsx
source={source}
width={'100%'}
height={'100%'}
aspectRatio={aspectRatio}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: styleq: aspectRatio typeof 1 is not "string" or "null".

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:55pm

@felicio felicio requested review from a team, jkbktl, prichodko and marcelines June 6, 2024 15:50
marcelines
marcelines approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@marcelines marcelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

packages/components/src/image/image.tsx

const Image = (props: Props, ref: Ref<HTMLImageElement>) => {
const { src, radius = 'none', aspectRatio, ...imageProps } = props

// const {borderRadius, ...rest} = imageProps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this?

@felicio felicio mentioned this pull request Sep 23, 2024
Merged
26 tasks
@felicio
Copy link
Collaborator Author

felicio commented Sep 23, 2024

#523

@felicio felicio closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbktl jkbktl jkbktl approved these changes

@marcelines marcelines marcelines approved these changes

@prichodko prichodko Awaiting requested review from prichodko prichodko was automatically assigned from status-im/web

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felicio @jkbktl @marcelines