Skip to content

Commit

Permalink
fix: Container attribute needs to refer advice target
Browse files Browse the repository at this point in the history
  • Loading branch information
ManuelGerding committed Dec 6, 2023
1 parent 3013a97 commit ccef8d6
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion extadvice/cpu_limit/action_needed_summary.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
When your containers of ${target.steadybit.label} use too much CPU, other pods on the same node may suffer and become unstable.

**Container affected:** ${k8s.container.spec.limit.cpu.not-set[]}
**Container affected:** ${target.k8s.container.spec.limit.cpu.not-set[]}
2 changes: 1 addition & 1 deletion extadvice/cpu_request/action_needed_summary.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
When your containers of ${target.steadybit.label} requests unnecessary high CPU, you're wasting resources by over-allocating and making it unlikely to schedule your pod on available node resources.

**Container affected:** ${k8s.container.spec.request.cpu.not-set[]}
**Container affected:** ${target.k8s.container.spec.request.cpu.not-set[]}
2 changes: 1 addition & 1 deletion extadvice/liveness_probe/action_needed_summary.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Kubernetes cannot detect unresponsive pods/container of ${target.steadybit.label} and thus will never restart them automatically.
Eventually, this may cause to become unavailable.

**Container affected:** ${k8s.container.probes.liveness.not-set[]}
**Container affected:** ${target.k8s.container.probes.liveness.not-set[]}
2 changes: 1 addition & 1 deletion extadvice/memory_limit/action_needed_summary.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
When your containers of ${target.steadybit.label} use too much memory, other pods on the same node may suffer and become unstable.

**Container affected:** ${k8s.container.spec.limit.memory.not-set[]}
**Container affected:** ${target.k8s.container.spec.limit.memory.not-set[]}
2 changes: 1 addition & 1 deletion extadvice/memory_request/action_needed_summary.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
When your containers of ${target.steadybit.label} requests unnecessary high memory, you're wasting resources by over-allocating and making it unlikely to schedule your pod on available node resources.

**Container affected:** ${k8s.container.spec.request.cpu.not-set[]}
**Container affected:** ${target.k8s.container.spec.request.cpu.not-set[]}
2 changes: 1 addition & 1 deletion extadvice/readiness_probe/action_needed_summary.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
When Kubernetes redeploys ${target.steadybit.label}, it can't determine when the following container are ready to accept incoming requests.
They may receive requests before being able to handle them properly.

**Container affected:** ${k8s.container.probes.readiness.not-set[]}
**Container affected:** ${target.k8s.container.probes.readiness.not-set[]}
3 changes: 1 addition & 2 deletions extadvice/single_replica/instructions.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
Change ```ReplicaSet``` to two (or more) in your Kubernetes configuration in order to increase the scheduling of additional pods. The availability of your service ${target.steadybit.label} will most likely improve.

**If you increase the replica we strongly advice you to check if this is supported by your application.**

```yaml
apiVersion: apps/v1
kind: ReplicaSet
Expand All @@ -18,3 +16,4 @@ spec:
matchLabels:
tier: ${target.steadybit.label}
```
**If you increase the replica we strongly advice you to check if this is supported by your application.**

0 comments on commit ccef8d6

Please sign in to comment.