prevent runtime override of model

steamship-core · Nov 17, 2023 · 6896d61 · 6896d61
1 parent 8d6e5f9
commit 6896d61
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/api.py b/src/api.py
@@ -217,6 +217,13 @@ def run(
         return InvocableResponse(data=RawBlockAndTagPluginOutput(blocks=generated_blocks))
 
     def _inputs_from_config_and_runtime_params(self, options: Optional[dict]) -> dict:
+
+        if options is not None and "model" in options:
+            raise SteamshipError(
+                "Model may not be overridden in runtime options. "
+                "Please configure 'model' when creating a plugin instance."
+            )
+
         temp_config = DallEPlugin.DallEPluginConfig(**self.config.dict())
         temp_config.extend_with_dict(options, overwrite=True)
         validated_config = DallEPlugin.DallEPluginConfig(**temp_config.dict())

diff --git a/test/test_unit.py b/test/test_unit.py
@@ -80,3 +80,10 @@ def test_runtime_config_validation_returns_values():
     assert config_dict.get("size") == ImageSizeEnum.large
     assert config_dict.get("n") == 1
     assert config_dict.get("style")
+
+
+def test_no_override_of_model_at_runtime():
+    plugin = DallEPlugin(config={"model": "dall-e-2"})
+
+    with pytest.raises(SteamshipError):
+        plugin._inputs_from_config_and_runtime_params(options={"model": "dall-e-3"})