bugfix: Avoid null reference to last_user_message in ChatHistory #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-reid
reviewed
Oct 7, 2023
| context.chat_history.search(context.chat_history.last_user_message.text, k=3) | ||
| .wait() | ||
| .to_ranked_blocks() | ||
| context.chat_history.search(_last_user_message, k=3).wait().to_ranked_blocks() |
There was a problem hiding this comment.
Suggested change
| context.chat_history.search(_last_user_message, k=3).wait().to_ranked_blocks() | |
| context.chat_history.search(_last_user_message.text, k=3).wait().to_ranked_blocks() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@douglas-reid I'm not 100% sure if I'm fixing an error or enabling odd uses of ChatHistory, but some experiments I was doing in the game resulted in attempting to do a completion on a history where the user hadn't yet chimed in, and that caused None-deferences in the code touched in this PR.
Does this look OK to you? I gave it an eyeball scan, but I know this code is very delicate..