Fix Middleware Classifier for Laravel 11 (#223)

* Rename variables

* Remove unused getEnvironmentSetup

* Use Middleware from Router in Middleware Classifier

* Update Tests

* Support Rector v1

composer.json

@@ -29,7 +29,7 @@
         "orchestra/testbench": "^7.0 | ^8.0 | ^9.0",
         "pestphp/pest": "^1 || ^2",
         "phpunit/phpunit": "^9.0 | ^10.0 | ^11.0",
-        "rector/rector": "^0.15",
+        "rector/rector": "^0.15|^1.0",
         "vimeo/psalm": "^5.0"
     },
     "autoload": {

src/Classifiers/MiddlewareClassifier.php

@@ -2,6 +2,7 @@
 
 namespace Wnx\LaravelStats\Classifiers;
 
+use Illuminate\Routing\Route;
 use ReflectionProperty;
 use Illuminate\Contracts\Http\Kernel;
 use Wnx\LaravelStats\ReflectionClass;
@@ -21,19 +22,21 @@ public function satisfies(ReflectionClass $class): bool
     {
         $this->httpKernel = $this->getHttpKernelInstance();
 
-        $middleware = $this->getMiddleware();
+        $middlewares = $this->getMiddlewares();
 
-        if (in_array($class->getName(), $middleware)) {
+        if (in_array($class->getName(), $middlewares)) {
             return true;
         }
 
-        return collect($middleware)
+        return collect($middlewares)
             ->merge($this->getMiddlewareGroupsFromKernel())
+            ->merge($this->getRouteMiddlewares())
             ->flatten()
+            ->unique()
             ->contains($class->getName());
     }
 
-    protected function getMiddleware(): array
+    protected function getMiddlewares(): array
     {
         $reflection = new ReflectionProperty($this->httpKernel, 'middleware');
         $reflection->setAccessible(true);
@@ -77,4 +80,18 @@ public function countsTowardsTests(): bool
     {
         return false;
     }
+
+    private function getRouteMiddlewares(): array
+    {
+        $reflection = new ReflectionProperty($this->httpKernel, 'router');
+        $reflection->setAccessible(true);
+
+        $router = $reflection->getValue($this->httpKernel);
+
+        return collect($router->getRoutes()->getRoutes())
+            ->map(fn (Route $route) => $route->middleware())
+            ->flatten()
+            ->unique()
+            ->toArray();
+    }
 }

tests/Classifiers/MiddlewareClassifierTest.php

@@ -2,6 +2,8 @@
 
 namespace Wnx\LaravelStats\Tests\Classifiers;
 
+use Orchestra\Testbench\Attributes\DefineRoute;
+use PHPUnit\Framework\Attributes\Test;
 use Wnx\LaravelStats\Tests\TestCase;
 use Wnx\LaravelStats\ReflectionClass;
 use Illuminate\Routing\Middleware\ThrottleRequests;
@@ -10,13 +12,23 @@
 
 class MiddlewareClassifierTest extends TestCase
 {
-    /** @test */
-    public function it_returns_true_if_given_class_is_a_middleware()
+    /**
+     * Define routes setup.
+     *
+     * @param  \Illuminate\Routing\Router  $router
+     * @return void
+     */
+    protected function usesMiddlewareRoutes($router)
     {
-        if ($this->getLaravelVersion() === 11.0) {
-            $this->markTestSkipped("Middleware classification currently broken in Laravel 11.");
-        }
+        $router->get('/demo', function () {
+            return 'Hello World';
+        })->middleware(DemoMiddleware::class);
+    }
 
+    #[Test]
+    #[DefineRoute('usesMiddlewareRoutes')]
+    public function it_returns_true_if_given_class_is_a_middleware(): void
+    {
         $this->assertTrue(
             (new MiddlewareClassifier())->satisfies(
                 new ReflectionClass(DemoMiddleware::class)

tests/TestCase.php

@@ -25,13 +25,6 @@ protected function getPackageProviders($app)
         ];
     }
 
-    /**
-     * @param \Illuminate\Foundation\Application $app
-     */
-    protected function getEnvironmentSetUp($app)
-    {
-    }
-
     /**
      * Resolve application HTTP Kernel implementation.
      *