Fix double rendering of union types

stefna · Nov 21, 2024 · adb23fb · adb23fb
1 parent 8e110fd
commit adb23fb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/ValueObject/Type.php b/src/ValueObject/Type.php
@@ -177,7 +177,10 @@ public function getTypeHint(bool $renderUnion = false): ?string
 			if ($renderUnion) {
 				$typeHint = [];
 				foreach ($this->getUnionTypes() as $unionType) {
-					$typeHint[] = $unionType->getTypeHint();
+					$unionTypeHint = $unionType->getTypeHint();
+					if (!in_array($unionTypeHint, $typeHint)) {
+						$typeHint[] = $unionTypeHint;
+					}
 				}
 				if ($this->isNullable() && !in_array('mixed', $typeHint)) {
 					array_unshift($typeHint, 'null');

diff --git a/tests/ValueObject/TypeTest.php b/tests/ValueObject/TypeTest.php
@@ -353,4 +353,12 @@ public function testEnumStringValueNullableAndClass(): void
 		$this->assertNull($type->getTypeHint());
 		$this->assertNull($type->getTypeHint(true));
 	}
+
+	public function testDontDoubleRenderUnionTypes(): void
+	{
+		$type = Type::fromString('array<int>');
+		$type->addUnion('array<string>');
+
+		$this->assertSame('array', $type->getTypeHint(true));
+	}
 }