Don't reopen GUIs on update when not necessary to prevent flickering #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps paper-nms-maven-plugin from 1.2 to 1.2.1. --- updated-dependencies: - dependency-name: ca.bkaw:paper-nms-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…some logic from NamedGui to Gui to support Beacon GUIs, fixed double opening for Workbench GUIs
jdkeke142
changed the title
|
Thank you for your PR. I've changed the base to version 0.10.7, since I need more time to look at this and want to get an update out to add support for Minecraft 1.19. |
I see. If you want me to change anything let me know |
stefvanschie
requested changes
Jul 4, 2022
There was a problem hiding this comment.
Sorry for the delay in getting to this. There are some guis that don't behave properly with these changes. In particular:
- The AnvilGui doesn't place items back in the player inventory after updating the gui. An item on the cursor is also only visible after the gui has been updated.
- In the BeaconGui, when you pick up an item from the player inventory, it becomes invisible/disappears.
- For the CartographyTableGui, when you take an item from the top inventory the item is duplicated, but when you take an item form the bottom inventory it disappears.
- In the CraftingTableGui, items in the player inventory aren't visible.
- In the EnchantingTableGui taking an item causes it to become invisible/disappear.
- In the GrindstoneGui when you take an item it is duplicated.
- And for the StonecutterGui you cannot take any items, even if the event for this item is not cancelled.
The other guis seem to be working correctly.
|
This was closed automatically along the deletion of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A current problem with IF is that with each GUI update, even when only items are changed, it reopens the inventory which causes some kinds of flickering.
For a static GUI or one that updates rarely this is not a big concern. However, as stated in the issue #205, it becomes a bigger problem in GUIs that need to be updated more frequently.
This PR is intended to correct the problem without changing the external use of the API, now Gui#update will judge itself if it is necessary to reopen the GUI depending on whether it is considered dirty or not.