Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Update RPC docs for clarify on deprecation of postional array and costs #721

Merged
merged 10 commits into from
Feb 15, 2024

Conversation

janewang
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be better served denoting the by-name nature of the params in a different way than adding it to multiple descriptions.

I agree that the numbered list of params can definitely make it appear like py-position is a valid way to submit a request. I don't know if there's a built-in way to modify that with the plugin we're using, but I can definitely check into it.

diff Outdated Show resolved Hide resolved
openrpc/src/methods/simulateTransaction.json Show resolved Hide resolved
openrpc/src/contentDescriptors/Transaction.json Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the help with this!

@ElliotFriend ElliotFriend merged commit b2d694b into main Feb 15, 2024
2 checks passed
@ElliotFriend ElliotFriend deleted the dep-array-params branch February 15, 2024 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants