handle undefined flag val (#904) (#905)

stellar · Jul 19, 2023 · 61ebf27 · 61ebf27
1 parent 78db4bb
commit 61ebf27
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 11 deletions.
diff --git a/extension/src/popup/components/signTransaction/Operations/index.tsx b/extension/src/popup/components/signTransaction/Operations/index.tsx
@@ -190,12 +190,14 @@ const PathList = ({ paths }: { paths: [Path] }) => {
 const FlagList = ({ flags }: { flags: FLAGS }) => (
   <>
     {Object.entries(flags).map(([flag, value]) => (
-      <div key={flag}>
-        <KeyValueList
-          operationKey={FLAG_TYPES[flag as keyof typeof FLAG_TYPES]}
-          operationValue={value.toString()}
-        />
-      </div>
+      <KeyValueList
+        key={flag}
+        operationKey={FLAG_TYPES[flag as keyof typeof FLAG_TYPES]}
+        operationValue={
+          // clawbackEnabled will be undefined if not being cleared
+          typeof value === "undefined" ? "undefined" : value.toString()
+        }
+      />
     ))}
   </>
 );

diff --git a/extension/src/popup/views/__tests__/SignTransaction.test.tsx b/extension/src/popup/views/__tests__/SignTransaction.test.tsx
@@ -21,9 +21,20 @@ const defaultSettingsState = {
   },
 };
 
-const defaultTransactionInfo = {
+const mockTransactionInfo = {
   accountToSign: "",
-  transaction: { _networkPassphrase: "foo" },
+  transaction: {
+    _networkPassphrase: "foo",
+    _operations: [
+      {
+        flags: {
+          authorized: true,
+          authorizedToMaintainLiabilities: false,
+          clawbackEnabled: undefined,
+        },
+      },
+    ],
+  },
   transactionXdr: "",
   domain: "",
   domainTitle: "",
@@ -39,7 +50,7 @@ jest.mock("stellar-sdk", () => {
   return {
     ...original,
     TransactionBuilder: {
-      fromXDR: () => defaultTransactionInfo.transaction,
+      fromXDR: () => mockTransactionInfo.transaction,
     },
   };
 });
@@ -52,7 +63,7 @@ describe("SignTransactions", () => {
   it("renders", async () => {
     jest
       .spyOn(Stellar, "getTransactionInfo")
-      .mockImplementation(() => defaultTransactionInfo);
+      .mockImplementation(() => mockTransactionInfo);
 
     render(
       <Wrapper
@@ -68,7 +79,7 @@ describe("SignTransactions", () => {
   });
   it("shows non-https domain error", async () => {
     jest.spyOn(Stellar, "getTransactionInfo").mockImplementation(() => ({
-      ...defaultTransactionInfo,
+      ...mockTransactionInfo,
       isHttpsDomain: false,
     }));
     render(