add Blockaid announcement modal #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piyalbasu
commented
Sep 5, 2024
piyalbasu
commented
piyalbasu
commented
Sep 5, 2024
| @@ -74,7 +74,7 @@ export const Preferences = () => { | |||
| <AutoSaveFields /> | |||
| <div className="Preferences--section"> | |||
| <div className="Preferences--section--title"> | |||
| {t("Verification with")} stellar.expert & blockaid.io | |||
| {t("Verification with")} stellar.expert | |||
There was a problem hiding this comment.
Copy change after chatting with product
piyalbasu
commented
Sep 5, 2024
| @@ -30,7 +30,6 @@ export const SignMessageDemo = () => { | |||
| if (signedMessageObj.error) { | |||
| setResult(JSON.stringify(signedMessageObj.error)); | |||
| } else { | |||
| console.log(signedMessageObj); | |||
There was a problem hiding this comment.
unrelated - but noticed this errant console.log
piyalbasu
commented
Sep 5, 2024
| @@ -446,7 +445,7 @@ export const ScamAssetWarning = ({ | |||
| )} | |||
| </div> | |||
| <div className="ScamAssetWarning__btns"> | |||
| {!isValidatingSafeAssetsEnabled && !isSendWarning && ( | |||
| {!isSendWarning && ( | |||
There was a problem hiding this comment.
sorry for another slightly unrelated change - but product says that a blockaid warning should not block the ability to sign something
aristidesstaffieri
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.