add better typing for standalone balances #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Sep 10, 2024
| const v: any = resp.balances[k]; | ||
| if (v.liquidity_pool_id) { | ||
| const v = resp.balances[k]; | ||
| if (v.liquidityPoolId) { |
There was a problem hiding this comment.
fixed this key to be camelcase rather than snake
piyalbasu
commented
Sep 11, 2024
| const { balances, subentry_count, num_sponsored, num_sponsoring } = | ||
| accountDetails; | ||
|
|
||
| const displayableBalances = Object.values(balances).reduce( |
There was a problem hiding this comment.
using reduce made it hard for TS to typecheck the different balance types. Switching to a for loop for more clarity.
Also, at some point balances must have changed from an object to an array. No need to do this Object.values conversion
piyalbasu
commented
Sep 11, 2024
| reserves: lp.reserves, | ||
| }; | ||
| delete balances[k].liquidity_pool_id; |
There was a problem hiding this comment.
initially, we assigned liquidity_pool_id's value to liquidityPoolId and then deleted the old liquidity_pool_id. I'm just simplifying the logic in makeDisplayableBalances so we don't need to do this anymore
aristidesstaffieri
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I added
blockaidDatato the BE's balances which caused the balances we get from the BE to be out of sync with the balances we get using a custom network. This should have raised type errors throughout the app, but it did not because we used a lot of casting asanywith balances to work our way out of some tricky type issues.I'm removing the use of
anywhen dealing with balances so we have a strongly typed (and more predictable) format for balances