Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add helper to determine if a tx is suspicious #1497

Merged
merged 2 commits into from
Sep 26, 2024
Merged

add helper to determine if a tx is suspicious #1497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b14b65
add helper to determine if a tx is suspicious
piyalbasu Sep 25, 2024
00d3417
Merge branch 'release/5.23.2' into feature/suspicious-tx-helper
piyalbasu Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension/src/popup/components/sendPayment/SendConfirm/SubmitResult/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ export const SubmitSuccess = ({ viewDetails }: { viewDetails: () => void }) => {
);
const isHardwareWallet = !!useSelector(hardwareWalletTypeSelector);
const isSourceAssetSuspicious = isAssetSuspicious(
accountBalances.balances?.[asset].blockaidData,
accountBalances.balances?.[asset]?.blockaidData,
);
const isDestAssetSuspicious = isAssetSuspicious(
accountBalances.balances?.[destinationAsset].blockaidData,
accountBalances.balances?.[destinationAsset]?.blockaidData,
);

const removeTrustline = async (assetCode: string, assetIssuer: string) => {
Expand Down
5 changes: 4 additions & 1 deletion extension/src/popup/components/sendPayment/SendConfirm/TransactionDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
} from "@shared/helpers/stellar";
import {
isAssetSuspicious,
isTxSuspicious,
useScanAsset,
useScanTx,
} from "popup/helpers/blockaid";
Expand Down Expand Up @@ -728,7 +729,9 @@ export const TransactionDetails = ({ goBack }: { goBack: () => void }) => {
<Button
size="md"
variant={
isSourceAssetSuspicious || isDestAssetSuspicious
isSourceAssetSuspicious ||
isDestAssetSuspicious ||
(scanResult && isTxSuspicious(scanResult))
? "error"
: "primary"
}
Expand Down
22 changes: 22 additions & 0 deletions extension/src/popup/helpers/blockaid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,28 @@ export const isAssetSuspicious = (blockaidData?: BlockAidScanAssetResult) => {
return blockaidData.result_type !== "Benign";
};

export const isTxSuspicious = (blockaidData: BlockAidScanTxResult) => {
const { simulation, validation } = blockaidData;

if (!blockaidData) {
return false;
}

if (simulation && "error" in simulation) {
return true;
}

if (
validation &&
"result_type" in validation &&
validation.result_type !== "Benign"
) {
return true;
}

return false;
};

export const scanAssetBulk = async (
addressList: string[],
networkDetails: NetworkDetails,
Expand Down