Skip spotless tasks in Github actions to accelerate the CI #1021
Conversation
|
Reference Server Preview is available here: |
lijamie98
force-pushed
the
feature/skip-spotless-in-GH-actions
branch
from
ab434bc
to
6d592e1
Compare
|
Reference Server Preview is available here: |
lijamie98
force-pushed
the
feature/skip-spotless-in-GH-actions
branch
from
6d592e1
to
ac94812
Compare
|
Reference Server Preview is available here: |
lijamie98
force-pushed
the
feature/skip-spotless-in-GH-actions
branch
from
ac94812
to
01f3716
Compare
|
Reference Server Preview is available here: |
| @@ -47,7 +51,7 @@ jobs: | |||
| - name: Gradle test and build. (unit tests, integration tests, end-2-end tests and build) | |||
| env: | |||
| run_docker: false | |||
| run: ./gradlew clean build --no-daemon --stacktrace | |||
| run: ./gradlew clean build --no-daemon --stacktrace -x spotlessApply -x spotlessCheck -x spotlessKotlin -x spotlessKotlinApply -x javadoc -x javadocJar -x sourcesJar | |||
There was a problem hiding this comment.
I think we can skip spotlessApply, but not check. If a developer tries to submit unformatted code, we should be catching it in CI.
There was a problem hiding this comment.
@philipliu If spotlessCheck fails, does it fail the CI?
There was a problem hiding this comment.
Removed -x spotlessCheck
There was a problem hiding this comment.
Sorry, I missed this earlier, but we should keep spotlessKotlin too right?
There was a problem hiding this comment.
No problem at all. Thanks for catching these gotchas. I had removed -x spotlessKotlin.
lijamie98
force-pushed
the
feature/skip-spotless-in-GH-actions
branch
from
01f3716
to
7a9de59
Compare
|
Reference Server Preview is available here: |
lijamie98
force-pushed
the
feature/skip-spotless-in-GH-actions
branch
from
799d37f
to
a540f89
Compare
|
Reference Server Preview is available here: |
|
Something went wrong with PR preview build please check |
|
Reference Server Preview is available here: |
PR Checklist
PR Structure
otherwise).
paymentservice.stellar, orallordocif the changes are broad or impact manypackages.
Thoroughness
What
Skip spotless tasks in Github actions to accelerate the CI
Why
Optimization