-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANCHOR-408 helm-charts/sep-service helm chart observer metrics #1039
ANCHOR-408 helm-charts/sep-service helm chart observer metrics #1039
Conversation
Something went wrong with PR preview build please check |
I'm not the most qualified person to review these changes but LGTM. I'll approve once the tests pass. |
Something went wrong with PR preview build please check |
Something went wrong with PR preview build please check |
Something went wrong with PR preview build please check |
Something went wrong with PR preview build please check |
Something went wrong with PR preview build please check |
Something went wrong with PR preview build please check |
Reference Server Preview is available here: |
Looking at the deployed sep server in PR PReviews i see using default values:
observer ports
|
Reference Server Preview is available here: |
Reference Server Preview is available here: |
Reference Server Preview is available here: |
see stellar-anchor-platform-preview/3718/console |
This change updates the legacy/main-1.2 helm chart to externalize the optionalMetricsEnabled parameter and also add metrics port for the stellar observer.
PR Structure
otherwise).
paymentservice.stellar
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
I have tested this PR using helm template command. Results verified using example-values file and uncommenting the stellar observer section.
What
helm chart updates.
Why
partner needs to access metrics port for observer in order to integrate with datadog.
also needs to enable the optionalmetrics and need this parameter available in helm chart values.
Known limitations
Test Evidence:
helm template sepservice . -f example_values.yaml > ~/out