Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANCHOR-408 helm-charts/sep-service helm chart observer metrics #1039

Merged

Conversation

reecexlm
Copy link
Contributor

@reecexlm reecexlm commented Aug 4, 2023

This change updates the legacy/main-1.2 helm chart to externalize the optionalMetricsEnabled parameter and also add metrics port for the stellar observer.

PR Structure

  • [x ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • [x ] This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

I have tested this PR using helm template command. Results verified using example-values file and uncommenting the stellar observer section.

What

helm chart updates.

Why

partner needs to access metrics port for observer in order to integrate with datadog.
also needs to enable the optionalmetrics and need this parameter available in helm chart values.

Known limitations

Test Evidence:
helm template sepservice . -f example_values.yaml > ~/out

        optionalMetricsEnabled: true  # optional metrics that periodically query the database
        runInterval: 30                 # interval to query the database to generate the optional metrics
# Stellar Observer
apiVersion: apps/v1
kind: Deployment
metadata:
  name: anchor-platform-observer
---snip---
          ports:
          - name: http
            containerPort: 8083
            protocol: TCP
          - name: metrics
            containerPort: 8082
            protocol: TCP

@reecexlm reecexlm changed the base branch from develop to legacy/main-1.2 August 4, 2023 16:55
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@philipliu
Copy link
Contributor

I'm not the most qualified person to review these changes but LGTM. I'll approve once the tests pass.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1039.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1039.previews.kube001.services.stellar-ops.com/

@reecexlm
Copy link
Contributor Author

reecexlm commented Aug 4, 2023

Looking at the deployed sep server in PR PReviews i see using default values:

      metrics-service:
        optionalMetricsEnabled: false  # optional metrics that periodically query the database
        runInterval: 30                 # interval to query the database to generate the optional metrics

observer ports

          ports:
          - name: http
            containerPort: 8083
            protocol: TCP
          - name: metrics
            containerPort: 8082
            protocol: TCP

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1039.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1039.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1039.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1039.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1039.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1039.previews.kube001.services.stellar-ops.com/

@reecexlm
Copy link
Contributor Author

reecexlm commented Aug 4, 2023

see stellar-anchor-platform-preview/3718/console
updated helm values in preview and they were reflected in the configmap.
metrics-service:
optionalMetricsEnabled: true # optional metrics that periodically query the database
runInterval: 65 # interval to query the database to generate the optional metrics

@reecexlm reecexlm merged commit 057efab into legacy/main-1.2 Aug 4, 2023
3 checks passed
@reecexlm reecexlm deleted the reece-anchor-408-helm-chart-observer-metrics branch August 4, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants