Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hostname lookup from Sep10Config validation #1042

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Remove hostname lookup from Sep10Config validation #1042

merged 3 commits into from
Aug 8, 2023

Conversation

lijamie98
Copy link
Collaborator

@lijamie98 lijamie98 commented Aug 5, 2023 •
edited
Loading

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Remove hostname lookup from Sep10Config validation

Why

After discussion, we don't think this being necessary

Known limitations

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1042.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1042.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 force-pushed the hotfix/remove-sep10-hostname-validation branch from 8bdc523 to 0067290 Compare August 5, 2023 09:01
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1042.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1042.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 self-assigned this Aug 7, 2023
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1042.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1042.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1042.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1042.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 force-pushed the hotfix/remove-sep10-hostname-validation branch from b6a080d to be9aa05 Compare August 8, 2023 00:15
@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1042.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1042.previews.kube001.services.stellar-ops.com/

@lijamie98 lijamie98 merged commit 505ecfc into stellar:develop Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeUrban JakeUrban JakeUrban approved these changes

Assignees

@lijamie98 lijamie98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lijamie98 @stellar-jenkins @JakeUrban