SDFSOF-70: RPC Actions - Integration and End2End tests #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nchor-sdk into fireblocks_integration
### What Custody refunds ### Why Custody Services should support refunds for `do_stellar_refund` action
SDFSOF-121 - Updated logic to use lastUpdatedAt instead of createdAt What Fixed an issue that custody_transaction's updated_at timestamp might be updated back in time Why updated_at should contain the last update at timestamp
…ent the ignores refund object params, making a payment of amount)expected value instead (#5) ### What Custody transaction payment type fix ### Why Refund custody transaction has invalid payment type
…ent the ignores refund object params, making a payment of amount)expected value instead (#6) ### What Custody transaction refund fix ### Why Custody transaction refund is created incorrectly
…-sdk into SDFSOF-70
…-sdk into SDFSOF-70
…tellar-anchor-sdk into SDFSOF-70
…-sdk into SDFSOF-70
### What Memo type validation for custody services ### Why Some custody services, for example Fireblocks, may not support some memo types, for example `hash`
…tellar-anchor-sdk into SDFSOF-70
…-sdk into SDFSOF-70
### What Refund memo type validation for custody services ### Why Some custody services, for example Fireblocks, may not support some memo types, for example `hash`
SDFSOF-70: RPC Actions - Integration and End2End tests What Integration and End2End tests for RPC actions Why Tests should validate SEP-24/SEP-31 flows
|
Reference Server Preview is available here: |
### What RPC batch size limit ### Why We should limit batch size to prevent internal/custody errors
|
Reference Server Preview is available here: |
Ifropc
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
paymentservice.stellar, orallordocif the changes are broad or impact manypackages.
Thoroughness
What
Fireblocks, for example, doesn't supporthashmemo_type):SEP-24validation occurs during transaction creation andrequest_onchain_fundsRPC request.SEP-31validation occurs during transaction creation.SEP-24/SEP-31flows.Custody Server.Kotlin Reference Server/Anchor Platform/Custody Server:AnchorPlatformActionsEnd2EndTest- custody integration disabled / RPC enabledAnchorPlatformCustodyActionsEnd2EndTest- custody integration enabled / RPC enabledAnchorPlatformCustodyEnd2EndTest- custody integration enabled / RPC disabledAnchorPlatformEnd2EndTest(existing) - custody integration disabled / RPC disabledWhy
Fireblocks, may not support some memo types, for examplehash