[ANCHOR-295] Implement Kotlin reference server #1060

philipliu · 2023-08-22T21:02:03Z

PR Checklist

PR Structure

This PR has reasonably narrow scope (if not, break it down into smaller PRs).
This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

This PR adds tests for the most critical parts of the new functionality or fixes.

What

This PR implements the callback endpoints in the Kotlin reference server. It moves all the tests to use the sep24 service runner profile, which points to the Kotlin reference server. Another PR will delete the anchor-reference-server project.

Why

The Java reference server is deprecated.

Known limitations

N/A

This reverts commit 274d948.

stellar-jenkins · 2023-08-23T18:34:45Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

JakeUrban

🙌 I left a few questions but this looks great. I'm interested to hear your perspective on what its like to integrate with the anchor platform's interfaces generally.

JakeUrban · 2023-08-24T19:21:51Z

kotlin-reference-server/src/main/kotlin/org/stellar/reference/plugins/ConfigureAuth.kt

+  when (cfg.authSettings.type) {
+    AuthSettings.Type.JWT ->
+      authentication {
+        jwt("integration-auth") {


❓ Should we name this something different considering we'd use the same auth type in our persistent deployment eventually?

Change to endpoint-auth.

JakeUrban · 2023-08-24T19:31:39Z

kotlin-reference-server/src/main/kotlin/org/stellar/reference/callbacks/rate/RateRoute.kt

+          .countryCode(call.parameters["country_code"])
+          .expireAfter(call.parameters["expire_after"])
+          .clientId(call.parameters["client_id"])
+          .id(call.parameters["id"])


❓ id is not a parameter to our GET /rate callback, is this used by our integration tests?

The id is used to store quote at the reference server. I think we need more time to discuss whether to store the quote at AP or at the business server.

I think what Jake is trying to say is that id should not be passed in a first place, as it's generated on business server side, according to our current documentation

JakeUrban · 2023-08-24T19:34:30Z

...n-reference-server/src/main/kotlin/org/stellar/reference/callbacks/customer/CustomerRoute.kt

+    route("/invalidate_clabe") {
+      get("{id}") {


❓ I'm assuming this is used to setup an integration test? Any chance we can make the endpoint available only when deployed in that context? We could do this later when we add a persistent deployment too, so I'll leave it to you.

I put a comment in the code to consider enabling this endpoint only when testing.

JakeUrban · 2023-08-24T19:38:01Z

kotlin-reference-server/src/main/kotlin/org/stellar/reference/callbacks/rate/RateService.kt

+    val rate =
+      when {
+        request.id != null -> getRate(request.id)
+        request.sellAmount != null || request.buyAmount != null -> {


❓ I'm not sure I understand why we have this condition, won't validate_request() catch the case where this condition is not true?

This is to simplify the validate_request(). The validate request does not check the condition where both amounts are null. So, we need this condition outside validate_request() function. I think this is legit.

Rather than have one validation check outside the request, why can't this check be the first within the validate_request() function?

...server/src/main/kotlin/org/stellar/reference/callbacks/uniqueaddress/UniqueAddressService.kt

stellar-jenkins · 2023-08-29T11:06:11Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

lijamie98 · 2023-08-29T16:55:36Z

.run/Test - Integration Test - no fullstack.run.xml

@@ -23,7 +23,7 @@
    <option name="METHOD_NAME" value="" />
    <option name="TEST_OBJECT" value="class" />
    <envs>
-      <env name="TEST_PROFILE_NAME" value="default" />
+      <env name="TEST_PROFILE_NAME" value="sep24" />


I don't think we want to keep the sep24 test profile after we merge the Java and Kotlin reference servers.

lijamie98 · 2023-08-29T16:55:42Z

.run/Test - Integration Test - with fullstack.run.xml

@@ -23,7 +23,7 @@
    <option name="METHOD_NAME" value="" />
    <option name="TEST_OBJECT" value="class" />
    <envs>
-      <env name="TEST_PROFILE_NAME" value="default" />
+      <env name="TEST_PROFILE_NAME" value="sep24" />


I don't think we want to keep the sep24 test profile after we merge the Java and Kotlin reference servers.

lijamie98 · 2023-08-29T17:56:34Z

kotlin-reference-server/src/main/kotlin/org/stellar/reference/plugins/ConfigureAuth.kt

+  when (cfg.authSettings.type) {
+    AuthSettings.Type.JWT ->
+      authentication {
+        jwt("integration-auth") {


Change to endpoint-auth.

stellar-jenkins · 2023-08-29T18:13:05Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

stellar-jenkins · 2023-08-29T18:28:18Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

stellar-jenkins · 2023-08-29T19:02:44Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

stellar-jenkins · 2023-08-29T19:32:33Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

stellar-jenkins · 2023-08-29T19:57:54Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

stellar-jenkins · 2023-08-29T21:49:06Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

Ifropc · 2023-08-29T20:37:25Z

...n-reference-server/src/main/kotlin/org/stellar/reference/callbacks/customer/CustomerRoute.kt

+            .type(call.parameters["type"])
+            .lang(call.parameters["lang"])
+            .build()
+        try {


Can we create a helper function for try/catch errors -> respond with status code?

Ifropc · 2023-08-29T20:38:02Z

...n-reference-server/src/main/kotlin/org/stellar/reference/callbacks/customer/CustomerRoute.kt

+        }
+      }
+    }
+    route("/invalidate_clabe") {


There is a config flag that marks it's only for test. You can do if (flag) route { }

Ifropc · 2023-08-29T20:41:43Z

kotlin-reference-server/src/main/kotlin/org/stellar/reference/callbacks/rate/RateRoute.kt

+          .countryCode(call.parameters["country_code"])
+          .expireAfter(call.parameters["expire_after"])
+          .clientId(call.parameters["client_id"])
+          .id(call.parameters["id"])


I think what Jake is trying to say is that id should not be passed in a first place, as it's generated on business server side, according to our current documentation

stellar-jenkins · 2023-08-29T23:30:11Z

Reference Server Preview is available here:
https://anchor-ref-pr1060.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1060.previews.kube001.services.stellar-ops.com/

### Description The changes include: 1. Introduces a new plugin to catch and map exceptions to a HTTP error code. 2. Put the `/invalidate_clabe` endpoint behind a configuration. 3. Re-introduces the SEP-12 validation from stellar-anchor-tests. Previously, when a GET /customer request does not include an account/memo, the query does not assert that they are null. This caused a race when updating an account that maps to many customers. ### Context Address the comments from the previous PR #1060. ### Testing `./gradlew test` ### Known limitations N/A

philipliu added 16 commits August 21, 2023 14:56

Customer integration

b8ba116

Quotes

160e335

Fee service

bcd19ae

Unique Address

210a319

Some auth stuff

9c85f05

Server starts

2ddaaf4

JWT works

8fac62f

Rates

1d44fee

Remove SEP24 config

274d948

Fix test

30997dc

Refactor config

970340c

Revert "Remove SEP24 config"

0a7e6ce

This reverts commit 274d948.

Use sep24 profile

1c9e308

Fix gradle build

561d6c8

Cleanup

57389ef

Fix default config

2d6db06

philipliu force-pushed the feature/anchor-295-kotlin-reference branch from 29188cc to 2d6db06 Compare August 23, 2023 18:32

philipliu marked this pull request as ready for review August 23, 2023 18:54

stellar deleted a comment from stellar-jenkins Aug 23, 2023

JakeUrban reviewed Aug 24, 2023

View reviewed changes

Merge branch 'develop' into feature/anchor-295-kotlin-reference

cdb1ea9

Removed sep24 test profile

02a4138

Change integration-auth to endpoint-auth

d165937

lijamie98 reviewed Aug 29, 2023

View reviewed changes

Fix distributionWallet to distrubutionWalletMemo

b2a628e

Remove Java reference server

d4bbaff

Removed H2MigrationTest and SQLiteMigrationTest

e55133d

Fix the sep24 validation test failure

0141c1a

Ifropc reviewed Aug 29, 2023

View reviewed changes

temporarily take out SEP-12 validation

f48d2cb

JakeUrban approved these changes Aug 29, 2023

View reviewed changes

lijamie98 merged commit bdf0799 into stellar:develop Aug 29, 2023
6 checks passed

philipliu deleted the feature/anchor-295-kotlin-reference branch August 30, 2023 01:28

philipliu mentioned this pull request Aug 30, 2023

[ANCHOR-295] Cleanup Kotlin referencer server implementation #1071

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ANCHOR-295] Implement Kotlin reference server #1060

[ANCHOR-295] Implement Kotlin reference server #1060

philipliu commented Aug 22, 2023 •

edited

Loading

stellar-jenkins commented Aug 23, 2023

JakeUrban left a comment

JakeUrban Aug 24, 2023

lijamie98 Aug 29, 2023

JakeUrban Aug 24, 2023

lijamie98 Aug 29, 2023

Ifropc Aug 29, 2023

JakeUrban Aug 24, 2023

lijamie98 Aug 29, 2023

JakeUrban Aug 24, 2023

lijamie98 Aug 29, 2023

JakeUrban Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

lijamie98 Aug 29, 2023

lijamie98 Aug 29, 2023

lijamie98 Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

Ifropc Aug 29, 2023

Ifropc Aug 29, 2023

Ifropc Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

[ANCHOR-295] Implement Kotlin reference server #1060

[ANCHOR-295] Implement Kotlin reference server #1060

Conversation

philipliu commented Aug 22, 2023 • edited Loading

PR Structure

Thoroughness

What

Why

Known limitations

stellar-jenkins commented Aug 23, 2023

JakeUrban left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-jenkins commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

stellar-jenkins commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-jenkins commented Aug 29, 2023

philipliu commented Aug 22, 2023 •

edited

Loading