SDFSOF-123: End2End tests for SEP-31 and sync with develop #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Renaming of RPC actions to RPC requests/methods ### Why Request/method is more general term than action
…tellar-anchor-sdk into fireblocks_integration
…to pending_anchor/pending_received when the stellar transction with requested memo and amount completed on the network (#17) ### What Find transaction by `toAccount` + `memo` combination to handle payment ### Why `SEP-31` payments are not handled correctly
…tellar-anchor-sdk into fireblocks_integration
### What Validation for deposit info generator type ### Why If custody integration is enabled, then only `custody` type should be available. If custody integration is disabled, then `custody` type should be not available.
…dk into fireblocks_integration
### Description End2End tests for SEP-31 ### Context There are no End2End tests for SEP-31
…r-anchor-sdk into fireblocks_integration
|
Reference Server Preview is available here: |
|
Hi, @Ifropc It looks like the validation of callbacks is invalid in End2End tests and callbacks themselves also work partially incorrectly.
Tests don't fail, because code, that should assert the error, is not executed, since We also added code to validate callbacks in our new End2End test for custody/RPC/SEP-31, but commented it and left TODOs to investigate this problem. In the examples below, there are 4 events, but 8 callbacks(with duplicates and some requests are missing). Example of events: Example of callbacks: |
|
Reference Server Preview is available here: |
…r-anchor-sdk into fireblocks_integration
|
Reference Server Preview is available here: |
Ifropc
reviewed
Sep 1, 2023
| expectedEvents: List<AnchorEvent>, | ||
| actualEvents: List<AnchorEvent> | ||
| ) { | ||
| expectedEvents.forEachIndexed { index, expectedEvent -> |
There was a problem hiding this comment.
Why do we modify expectedEvent before comparing it to actualEvent?
There was a problem hiding this comment.
Because some fields are dynamic(for example dates) and can not be specified in expectedEvent. The same logic is used in existing End2End tests - Sep24End2EndTests
| actualEvent.transaction.amountIn?.let { | ||
| expectedEvent.transaction.amountIn.amount = actualEvent.transaction.amountIn.amount | ||
| expectedEvent.transaction.amountIn.asset = asset.sep38 | ||
| // expectedEvent.transaction.amountIn.asset = |
There was a problem hiding this comment.
Some fileds assignment is commented-out, is it expected?
There was a problem hiding this comment.
I removed this commented code
| ) | ||
| } | ||
| } catch (e: ClientException) { | ||
| log.error(e) | ||
| call.respond(ErrorResponse(e.message!!)) | ||
| call.respond(MessageResponse(e.message!!)) |
There was a problem hiding this comment.
Why ErrorRespond was changed to MessageRespond in places where exceptions are caught?
There was a problem hiding this comment.
It was renamed from ErrorResponse to MessageResponse just because it has a field called msg and I wanted to add a new error response with error field. But now it looks like it is redundant, so I will use only the old ErrorResponse
|
Reference Server Preview is available here: |
…dk into fireblocks_integration
|
Reference Server Preview is available here: |
Fix validation of callbacks in E2E tests
|
Reference Server Preview is available here: |
…tellar-anchor-sdk into fireblocks_integration # Conflicts: # platform/src/test/kotlin/org/stellar/anchor/platform/service/PaymentOperationToEventListenerTest.kt
Ifropc
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SEP-31flowdevelopbranchTesting
./gradlew testCUSTODY_TYPE=fireblocks CUSTODY_FIREBLOCKS_VAULT_ACCOUNT_ID=<your_value> SECRET_CUSTODY_FIREBLOCKS_API_KEY=<your_value> SECRET_CUSTODY_FIREBLOCKS_SECRET_KEY=<your_value> ./gradlew clean testFireblocksE2E